Remove legacy CUDA modules for HCAL unpacking and local reconstruction

[fwyzard]

PR description:

Remove legacy CUDA modules for HCAL local reconstruction.
The alpaka version has been commissioned and used in production.

Remove legacy CUDA modules for HCAL unpacker.
The outcome of the discussion with the HCAL DPG is that:

• for Run 3 we should use the legacy cpu unpacker, and the alpaka version of the legacy-to-SoA converter;
• for Phase 2 the decision can be revisited once the final raw and digi formats are defined.

PR validation:

None.

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[fwyzard]

FYI @mariadalfonso @kakwok @igv4321.

Let me know if you spot other left overs.
I plan to remove the actual workflows in a separate PR.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46004/41783

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/Configuration/python/hcalLocalReco_cff.py modified in PR(s): Infrastructure for using channel-dependent pulse shapes for HB/HE #45995

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• CUDADataFormats/HcalDigi (reconstruction, heterogeneous)
• CUDADataFormats/HcalRecHitSoA (reconstruction, heterogeneous)
• CondFormats/DataRecord (db, alca)
• CondFormats/HcalObjects (db, alca)
• EventFilter/HcalRawToDigi (reconstruction)
• RecoLocalCalo/Configuration (reconstruction)
• RecoLocalCalo/HcalRecAlgos (reconstruction)
• RecoLocalCalo/HcalRecProducers (reconstruction)

@consuegs, @francescobrivio, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @sameasy, @seemasharmafnal, @thomreis, @tocheng, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cac56d/41511/summary.html
COMMIT: 317f4c2
CMSSW: CMSSW_14_2_X_2024-09-13-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46004/41511/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
• 8.08.0_BeamHalo/step3_BeamHalo.log
• 7.37.3_CosmicsSPLoose2018/step3_CosmicsSPLoose2018.log

Expand to see more relval errors ...

• 101.0

RelVals-INPUT

• 4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
• 134.813134.813_RunCosmics2015C/step2_RunCosmics2015C.log
• 136.733136.733_RunCosmics2016B/step2_RunCosmics2016B.log

Expand to see more relval errors ...

• 136.897
• 136.899
• 138.1
• 138.2
• 1005.0
• 1052.0

GPU Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 53003
• DQMHistoTests: Total failures: 886
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 52117
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 30 edm output root files, 7 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[perrotta]

+1

[jfernan2]

+1

[fwyzard]

ping @cms-sw/dqm-l2

[fwyzard]

ping @cms-sw/simulation-l2

[kpedro88]

+simulation
for simplifications in Validation/Configuration/python/ECALHCAL.py

[fwyzard]

ping @cms-sw/dqm-l2

[antoniovagnerini]

+dqm

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1