Removed cmsScimark2 exec and scripts #46235

smuzaffar · 2024-10-03T14:37:53Z

This PR drops cmsScimark2 binary and related scripts

cmsbuild · 2024-10-03T14:38:15Z

cms-bot internal usage

cmsbuild · 2024-10-03T14:39:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46235/42047

cmsbuild · 2024-10-03T14:39:34Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

Validation/Performance (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2024-10-03T14:56:43Z

@cmsbuild, please test

makortel · 2024-10-03T14:57:16Z

I didn't find any relevant references to cmsScimark2 or the removed scripts via Google or GitHub searches.

cmsbuild · 2024-10-03T18:17:57Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd5980/41922/summary.html
COMMIT: 4d7b451
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41922/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 101 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331336
DQMHistoTests: Total failures: 3231
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328085
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

makortel · 2024-10-03T18:55:36Z

Comparison differences are related to #39803

makortel · 2024-10-03T18:56:21Z

Umm, GitHub claims

This branch has conflicts that must be resolved

cmsbuild · 2024-10-03T19:37:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46235/42064

There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/Performance/bin/FFT.c modified in PR(s): [CORE] [Clang]Cleanup clang-analyzer warnings #46229
- File Validation/Performance/bin/array.c modified in PR(s): [CORE] [Clang]Cleanup clang-analyzer warnings #46229

cmsbuild · 2024-10-03T19:37:22Z

Pull request #46235 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

smuzaffar · 2024-10-03T19:39:27Z

please test

cmsbuild · 2024-10-03T19:41:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46235/42065

There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/Performance/bin/FFT.c modified in PR(s): [CORE] [Clang]Cleanup clang-analyzer warnings #46229
- File Validation/Performance/bin/array.c modified in PR(s): [CORE] [Clang]Cleanup clang-analyzer warnings #46229

cmsbuild · 2024-10-03T19:41:32Z

Pull request #46235 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

cmsbuild · 2024-10-03T21:42:29Z

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd5980/41946/summary.html
COMMIT: 9f34188
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd5980/41946/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd5980/41946/git-merge-result

RelVals

135.4

----- Begin Fatal Exception 03-Oct-2024 22:14:29 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CalibratedPatElectronProducer label='calibratedPatElectronsNano'
Exception Message:
edm::FileInPath unable to find file EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2016_UltraLegacy_postVFP_RunFineEtaR9Gain_v1_scales.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/135.4_ZEEFS_13
----- End Fatal Exception -------------------------------------------------

1330.0

----- Begin Fatal Exception 03-Oct-2024 22:24:00 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CalibratedPatElectronProducer label='calibratedPatElectronsNano'
Exception Message:
edm::FileInPath unable to find file EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2016_UltraLegacy_postVFP_RunFineEtaR9Gain_v1_scales.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/1330.0_ZMM_13
----- End Fatal Exception -------------------------------------------------

25202.0

----- Begin Fatal Exception 03-Oct-2024 22:36:13 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CalibratedPatElectronProducer label='calibratedPatElectronsNano'
Exception Message:
edm::FileInPath unable to find file EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2016_UltraLegacy_postVFP_RunFineEtaR9Gain_v1_scales.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41946/CMSSW_14_2_X_2024-10-03-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02857/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-10-03-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/25202.0_TTbar_13
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

2500.0012500.001_NANOmc106Xul16v2/step2_NANOmc106Xul16v2.log
2500.0112500.011_NANOdata106Xul16v2/step2_NANOdata106Xul16v2.log
2500.0312500.031_NANOdataUL16APVreMINI/step2_NANOdataUL16APVreMINI.log

Expand to see more relval errors ...

smuzaffar · 2024-10-04T06:05:29Z

please test

use latest IB

cmsbuild · 2024-10-05T17:32:56Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd5980/41992/summary.html
COMMIT: 9f34188
CMSSW: CMSSW_14_2_X_2024-10-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46235/41992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 103 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331336
DQMHistoTests: Total failures: 3375
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3327941
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

makortel · 2024-10-07T14:58:30Z

Comparison differences are related to #39803

makortel · 2024-10-07T14:58:43Z

+core

cmsbuild · 2024-10-07T14:58:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-07T16:37:37Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Oct 3, 2024

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Oct 3, 2024

smuzaffar mentioned this pull request Oct 3, 2024

[CORE] [Clang]Cleanup clang-analyzer warnings #46229

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2024

smuzaffar force-pushed the remove-cmsScimark2 branch from 4d7b451 to aad94a1 Compare October 3, 2024 19:33

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Oct 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2024

cmsbuild added code-checks-pending tests-started and removed code-checks-approved tests-pending labels Oct 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 3, 2024

cmsbuild added tests-started and removed tests-rejected labels Oct 5, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 5, 2024

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Oct 7, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 7, 2024

cmsbuild merged commit 36f3ed7 into cms-sw:master Oct 7, 2024
11 checks passed

cmsbuild mentioned this pull request Oct 7, 2024

Improve constructor for PhotonIsolationCalculator #46289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed cmsScimark2 exec and scripts #46235

Removed cmsScimark2 exec and scripts #46235

smuzaffar commented Oct 3, 2024 •

edited

Loading

cmsbuild commented Oct 3, 2024 •

edited

Loading

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

makortel commented Oct 3, 2024

makortel commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

makortel commented Oct 3, 2024

makortel commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

smuzaffar commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

smuzaffar commented Oct 4, 2024 •

edited

Loading

cmsbuild commented Oct 5, 2024

makortel commented Oct 7, 2024

makortel commented Oct 7, 2024

cmsbuild commented Oct 7, 2024

mandrenguyen commented Oct 7, 2024

Removed cmsScimark2 exec and scripts #46235

Removed cmsScimark2 exec and scripts #46235

Conversation

smuzaffar commented Oct 3, 2024 • edited Loading

cmsbuild commented Oct 3, 2024 • edited Loading

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

makortel commented Oct 3, 2024

makortel commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

Comparison Summary

makortel commented Oct 3, 2024

makortel commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

smuzaffar commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

RelVals

RelVals-INPUT

smuzaffar commented Oct 4, 2024 • edited Loading

cmsbuild commented Oct 5, 2024

Comparison Summary

makortel commented Oct 7, 2024

makortel commented Oct 7, 2024

cmsbuild commented Oct 7, 2024

mandrenguyen commented Oct 7, 2024

smuzaffar commented Oct 3, 2024 •

edited

Loading

cmsbuild commented Oct 3, 2024 •

edited

Loading

smuzaffar commented Oct 4, 2024 •

edited

Loading