[JMENano] Setup Pileup Jet ID for reclustered AK4 Puppi jets

[nurfikri89]

PR description:

Following up on PR #46191, this PR sets up the Pileup Jet ID for reclustered AK4 Puppi jets in JMENano. This should also address the failed RelVals workflows as reported in Issue #46221.

PR validation:

• passes the failed JMENano workflows: runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,11634.15,25202.15

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46244/42068

[cmsbuild]

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[mandrenguyen]

@nurfikri89 seems like the JMEnano tests are failing in the relval tests of this PR. Can you have a look?

[nurfikri89]

@nurfikri89 seems like the JMEnano tests are failing in the relval tests of this PR. Can you have a look?

Fixed now. Sorry about that.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46244/42074

[cmsbuild]

Pull request #46244 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again.

[iarspider]

please test

[hqucms]

Hi @nurfikri89 -- I am trying to understand why the failure did not show up in the NANO matrix test for JMENano (e.g., 2500.224_jmeNANOmc140X). Do you have a better clue?

[nurfikri89]

Hi @nurfikri89 -- I am trying to understand why the failure did not show up in the NANO matrix test for JMENano (e.g., 2500.224_jmeNANOmc140X). Do you have a better clue?

Hi @hqucms. You mean, why those workflows did not fail in Issue #46221? It is because of the run3_nanoAOD_pre142X modifier here, which is used to remove the puIdDisc branch for pre142X Minis:

https://github.com/nurfikri89/cmssw/blob/49af8f6914d894998541c589bfe5f4e78e4206e1/PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py#L138-L141

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a45504/41959/summary.html
COMMIT: 49af8f6
CMSSW: CMSSW_14_2_X_2024-10-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46244/41959/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331336
• DQMHistoTests: Total failures: 1436
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3329880
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[hqucms]

enable nano

[hqucms]

please test workflow 10224.15,11024.15,11634.15,25202.15

[hqucms]

Hi @nurfikri89 -- I am trying to understand why the failure did not show up in the NANO matrix test for JMENano (e.g., 2500.224_jmeNANOmc140X). Do you have a better clue?

Hi @hqucms. You mean, why those workflows did not fail in Issue #46221? It is because of the run3_nanoAOD_pre142X modifier here, which is used to remove the puIdDisc branch for pre142X Minis:

https://github.com/nurfikri89/cmssw/blob/49af8f6914d894998541c589bfe5f4e78e4206e1/PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py#L138-L141

OK I see. Thanks a lot for the explanation!

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a45504/41970/summary.html
COMMIT: 49af8f6
CMSSW: CMSSW_14_2_X_2024-10-04-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46244/41970/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
10224.15 step 5
11024.15 step 5
11634.15 step 3
25202.15 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 41 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 34 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3630798
• DQMHistoTests: Total failures: 3436
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3627340
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 211 log files, 183 edm output root files, 47 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 1875 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 55028
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 55028
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.949	2.949	0.000 ( +0.0% )	3.06	3.08	-0.7%	6.056	6.054
2500.002	3.059	3.059	0.000 ( +0.0% )	2.73	2.77	-1.3%	6.412	6.412
2500.003	3.003	3.003	0.000 ( +0.0% )	2.87	2.87	-0.0%	6.425	6.387
2500.011	1.534	1.534	0.000 ( +0.0% )	4.71	4.76	-1.1%	2.418	2.417
2500.012	2.031	2.031	0.000 ( +0.0% )	2.87	2.88	-0.1%	2.607	2.221
2500.013	1.873	1.873	0.000 ( +0.0% )	4.08	4.11	-0.8%	2.524	2.518
2500.021	0.022	0.022	0.000 ( +0.0% )	0.93	0.97	-4.0%	2.386	2.381
2500.022	0.022	0.022	0.000 ( +0.0% )	0.90	0.95	-5.3%	2.370	2.377
2500.023	0.022	0.022	0.000 ( +0.0% )	0.88	0.90	-2.3%	2.249	2.248
2500.024	0.022	0.022	0.000 ( +0.0% )	0.67	0.70	-5.0%	2.466	2.476
2500.031	0.035	0.035	0.000 ( +0.0% )	0.83	0.85	-2.9%	2.441	2.435
2500.032	0.036	0.036	0.000 ( +0.0% )	0.84	0.86	-2.1%	2.409	2.409
2500.033	0.037	0.037	0.000 ( +0.0% )	0.75	0.78	-2.7%	2.492	2.487
2500.034	0.036	0.036	0.000 ( +0.0% )	0.77	0.80	-3.7%	2.467	2.465
2500.101	2.732	2.732	0.000 ( +0.0% )	8.54	8.83	-3.3%	6.957	6.351
2500.111	1.389	1.389	0.000 ( +0.0% )	19.16	19.91	-3.7%	2.232	2.233
2500.112	1.806	1.806	0.000 ( +0.0% )	14.95	15.16	-1.4%	2.310	2.310
2500.131	0.747	0.747	0.000 ( +0.0% )	17.61	17.99	-2.1%	1.503	1.495
2500.201	2.557	2.557	0.000 ( +0.0% )	7.25	7.59	-4.4%	5.872	6.232
2500.211	1.700	1.700	0.000 ( +0.0% )	17.54	17.79	-1.4%	2.283	2.279
2500.212	2.096	2.096	0.000 ( +0.0% )	13.67	14.21	-3.8%	2.364	2.362
2500.221	2.004	2.004	0.000 ( +0.0% )	7.56	7.82	-3.3%	2.450	2.439
2500.222	3.281	3.281	0.000 ( +0.0% )	7.22	7.64	-5.4%	2.539	2.529
2500.223	8.968	8.968	0.000 ( +0.0% )	2.58	2.67	-3.2%	2.559	2.552
2500.224	5.815	5.787	0.028 ( +0.5% )	0.60	0.60	-1.2%	2.350	2.605
2500.225	5.833	5.805	0.028 ( +0.5% )	0.58	0.59	-1.3%	2.352	2.615
2500.226	3.044	3.044	0.000 ( +0.0% )	7.38	7.49	-1.4%	2.531	2.533
2500.227	1.437	1.437	0.000 ( +0.0% )	11.41	11.76	-3.0%	1.430	1.434
2500.231	1.404	1.404	0.000 ( +0.0% )	13.66	14.04	-2.7%	2.188	2.174
2500.232	2.301	2.301	0.000 ( +0.0% )	13.68	13.72	-0.3%	2.263	2.274
2500.233	4.748	4.748	0.000 ( +0.0% )	4.24	4.23	+0.3%	2.286	2.286
2500.234	3.518	3.501	0.017 ( +0.5% )	0.75	0.77	-1.5%	2.072	2.300
2500.235	3.530	3.513	0.017 ( +0.5% )	0.74	0.75	-0.9%	2.095	2.324
2500.236	2.145	2.145	0.000 ( +0.0% )	13.53	13.99	-3.2%	2.271	2.273
2500.237	1.016	1.016	0.000 ( +0.0% )	16.40	16.05	+2.2%	1.455	1.500
2500.241	9.404	9.404	0.000 ( +0.0% )	3.65	3.74	-2.3%	1.949	1.955
2500.242	10.331	10.331	0.000 ( +0.0% )	0.85	0.88	-3.7%	1.735	1.734
2500.243	2.712	2.712	0.000 ( +0.0% )	7.99	8.64	-7.5%	1.080	1.071
2500.244	485.976	485.976	0.000 ( +0.0% )	0.54	0.56	-2.3%	1.676	1.685
2500.245	823.202	823.202	0.000 ( +0.0% )	0.71	0.73	-3.0%	1.660	1.662
2500.901	1.777	1.777	0.000 ( +0.0% )	20.24	21.00	-3.6%	1.841	1.845
2500.902	1.626	1.626	0.000 ( +0.0% )	20.50	21.59	-5.0%	1.767	1.764
2500.911	13.995	13.995	0.000 ( +0.0% )	2.11	3.79	-44.5%	1.100	1.093
2500.912	0.240	0.240	0.000 ( +0.0% )	1.17	1.27	-7.6%	0.974	0.977
2500.913	0.110	0.110	0.000 ( +0.0% )	0.93	1.18	-21.2%	0.571	0.979

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1