[ML] [Clang]Cleanup clang-analyzer warnings #46318

smuzaffar · 2024-10-09T10:26:39Z

This PR fixes clang-analyzer warnings

cmsbuild · 2024-10-09T10:26:58Z

cms-bot internal usage

cmsbuild · 2024-10-09T10:28:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46318/42147

cmsbuild · 2024-10-09T10:29:02Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

PhysicsTools/MVAComputer (ml)

@cmsbuild, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-10-09T10:30:55Z

PhysicsTools/MVAComputer/interface/BitSet.h

-        store = nullptr;
+      assert(words);
+      store = new Word_t[words];
+      std::memcpy(store, orig.store, words * sizeof(Word_t));


I assume that bits_ > 0 and in that case bitsToWords(bits_) should always return words>0

smuzaffar · 2024-10-09T10:31:00Z

PhysicsTools/MVAComputer/interface/BitSet.h

-        store = nullptr;
+      assert(words);
+      store = new Word_t[words];
+      std::memset(store, 0, sizeof(Word_t) * words);


I assume that bits_ > 0 and in that case bitsToWords(bits_) should always return words>0

smuzaffar · 2024-10-09T10:39:40Z

please test

cmsbuild · 2024-10-09T12:32:13Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a33d4/42072/summary.html
COMMIT: 9b39e0a
CMSSW: CMSSW_14_2_X_2024-10-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46318/42072/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test testPhysicsToolsMVAComputer had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS

RelVals

135.4A fatal system signal has occurred: abort signal
5.1A fatal system signal has occurred: abort signal
9.0A fatal system signal has occurred: abort signal

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.901136.901_RunDoubleMuon2016C/step2_RunDoubleMuon2016C.log
136.902136.902_RunDoubleMuon2016H/step2_RunDoubleMuon2016H.log

Expand to see more relval errors ...

AddOn Tests

fastsim

A fatal system signal has occurred: abort signal

fastsim1

A fatal system signal has occurred: abort signal

fastsim2

A fatal system signal has occurred: abort signal

Expand to see more addon errors ...

smuzaffar · 2024-10-09T13:05:02Z

@cms-sw/ml-l2 , Looks like [VarProcessor::~VarProcessor()[(https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/MVAComputer/src/VarProcessor.cc#L42-L45) is explicitly calling inputVars = BitSet(0); . I do not think we need this call, the BitSet destructor should do the correct cleanup https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/MVAComputer/interface/BitSet.h#L150 .

Do you agree we can remove the following from the VarProcessor::~VarProcessor()

    inputVars = BitSet(0);
    nInputVars = 0;

smuzaffar · 2024-10-10T19:14:31Z

@cms-sw/ml-l2 , what do you think about #46318 (comment) ?

smuzaffar · 2024-10-11T07:38:11Z

please test

I have cleaned up ~VarProcessor

cmsbuild · 2024-10-11T07:39:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46318/42179

cmsbuild · 2024-10-11T07:39:47Z

Pull request #46318 was updated. @valsdav, @y19y19 can you please check and sign again.

cmsbuild · 2024-10-11T11:01:15Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a33d4/42121/summary.html
COMMIT: 37d6a21
CMSSW: CMSSW_14_2_X_2024-10-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46318/42121/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331066
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3331037
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-10-17T10:15:29Z

@cms-sw/ml-l2 , can youplease review this PR?

cmsbuild · 2024-11-22T13:12:15Z

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

cmsbuild · 2025-02-07T08:32:42Z

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

[ML] [Clang]Cleanup clang-analyzer warnings

9b39e0a

cmsbuild added this to the CMSSW_14_2_X milestone Oct 9, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending ml-pending labels Oct 9, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2024

smuzaffar commented Oct 9, 2024

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 9, 2024

remove unnessary clenup from ~VarProcessor

37d6a21

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Oct 11, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 11, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 11, 2024

cmsbuild modified the milestones: CMSSW_14_2_X, CMSSW_15_0_X Nov 22, 2024

cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] [Clang]Cleanup clang-analyzer warnings #46318

[ML] [Clang]Cleanup clang-analyzer warnings #46318

smuzaffar commented Oct 9, 2024

cmsbuild commented Oct 9, 2024 •

edited

Loading

cmsbuild commented Oct 9, 2024

cmsbuild commented Oct 9, 2024

smuzaffar Oct 9, 2024

smuzaffar Oct 9, 2024

smuzaffar commented Oct 9, 2024

cmsbuild commented Oct 9, 2024

smuzaffar commented Oct 9, 2024

smuzaffar commented Oct 10, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

smuzaffar commented Oct 17, 2024

cmsbuild commented Nov 22, 2024

cmsbuild commented Feb 7, 2025

[ML] [Clang]Cleanup clang-analyzer warnings #46318

Are you sure you want to change the base?

[ML] [Clang]Cleanup clang-analyzer warnings #46318

Conversation

smuzaffar commented Oct 9, 2024

cmsbuild commented Oct 9, 2024 • edited Loading

cmsbuild commented Oct 9, 2024

cmsbuild commented Oct 9, 2024

smuzaffar Oct 9, 2024

Choose a reason for hiding this comment

smuzaffar Oct 9, 2024

Choose a reason for hiding this comment

smuzaffar commented Oct 9, 2024

cmsbuild commented Oct 9, 2024

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

smuzaffar commented Oct 9, 2024

smuzaffar commented Oct 10, 2024

smuzaffar commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

cmsbuild commented Oct 11, 2024

Comparison Summary

smuzaffar commented Oct 17, 2024

cmsbuild commented Nov 22, 2024

cmsbuild commented Feb 7, 2025

cmsbuild commented Oct 9, 2024 •

edited

Loading