Jet updates for Mini and (JME)Nano, add recipe for puppi JetMET reclustering #46368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Use updateJetCollection to setup DeepJet and UParT for subjets. Cleanup postfix usage.
…T with MiniAOD as inputs. Useful when needed to update Puppi version.
- Add leading PF constituent information for reclustered AK4 Puppi jets. - Add wrapper function to also schedule rebuilding of slimmedJetsAK8. - Remove unused variables for AK4 CHS jets.
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46368/42207
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46368/42214
|
|
A new Pull Request was created by @nurfikri89 for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMOfflineConfigurationGotAll had ERRORS Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+1 |
|
ignore tests-rejected with ib-failure |
|
+1 |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR makes several changes in MiniAOD, NanoAOD and JMENano:
applySubstructure_cff.py, sync the AK8 jet pt cuts, when collecting PF constituents, for Run-2 MiniAOD with Run-3 RECO-level cuts.updateJetCollectionto setupDeepJetandUParTtaggers for AK8 subjets.applySubstructure_cff.py.subGenJetAK8Idxto match reco-level (SubJet) to gen-level(SubGenJetAK8) AK8 subjets.rawMassforCorrT1METJetcollection.@JMErePuppi) configuration to include rebuilding ofslimmedJetsAK8collection.The functions in
puppiJetMETReclusteringTools.pyandpuppiJetMETReclusteringFromMiniAOD_cff.pyscripts are designed to schedule the rebuilding of AK4 Puppi jets (slimmedJetsPuppi), AK8 Puppi jets (slimmedJetsAK8) and PuppiMET (slimmedMETsPuppi) with MiniAODs as input. The functions try to follow, as best as possible, how they are setup in the PAT step for MiniAOD production.These recipes were previously used to propagate Puppi tune studies through private NanoAOD production. We find it helpful to have these functions in CMSSW if, (a) we need to produce NanoAOD (privately or special validation campaigns), and (b) also for analyzers if they need to tune and update puppi in their analyses.
PR validation:
runTheMatrix.py -l limited -i all --ibeosrunTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034JMErePuppiworkflows:runTheMatrix.py -i all --ibeos -l 2500.225,2500.235