ZDC Reconstruction Bug Fixes

[matt2275]

PR description:

Bug Fixes:
ZdcSimpleRecAlgo_Run3.cc:
Simplified the formula for ChargeWeightedTime.
Fixed issue with integer division with TdcTime and updated code only call digi.le_tcd() once.

ZdcHitReconstruction_Run3.cc:
fixed issue with setZdcSaturation where the saturation was always 1 due to incorrect method to iterate over QIE10 digis. updated default value of setSaturationFlags to true

PR validation:

Tested on CMSSW_14_1_3 with runTheMatrix.py -l 142 -e --ibeos and passed all steps

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46429/42289

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46429/42289/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46429/42289/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46429/42291

[cmsbuild]

A new Pull Request was created by @matt2275 for master.

It involves the following packages:

• RecoLocalCalo/HcalRecAlgos (reconstruction)
• RecoLocalCalo/HcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @abdoulline, @apsallid, @argiro, @bsunanda, @mariadalfonso, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46429/42292

[cmsbuild]

Pull request #46429 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46429/42293

[cmsbuild]

Pull request #46429 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[mandrenguyen]

please test
I recommend that skipRPD remained set to True such that this code has no effect on existing workflows (it would anyway have crashed otherwise).
At this point, I think it best not to try to reco the RPD since the 14_1_3 release is already undergoing validation and T0 replay.
It's fine to fix the code, but further discussion would be needed before we include this in prompt reco.
Reviewers should feel free to visually inspect.

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa804a/42279/summary.html
COMMIT: e5974fc
CMSSW: CMSSW_14_2_X_2024-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46429/42279/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich make {DIGI,RECO}HI2024MIX steps consume the HIon HLT menu #46418
• @AdrianoDee New Tests PR Tests for HIN 2023 and 2024 #46419
• @fabiocos MTD Validation: Add printouts and protection for optional plots in BtlLocalRecoValidation #46408
• @mmusich Fix SiStripG2GainsValidator #46414
• @trackreco Phase-2 mkFit: propagation to plane / Kalman operations on plane / Matriplex with support for scalar operations and VDT #46325

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa804a/42279/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa804a/42279/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• You potentially added 39 lines to the logs
• Reco comparison results: 23785 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3335129
• DQMHistoTests: Total failures: 30088
• DQMHistoTests: Total nulls: 16
• DQMHistoTests: Total successes: 3305005
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.06999999999999998 KiB( 43 files compared)
• DQMHistoSizes: changed ( 140.023 ): 0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.043 ): -0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 140.063 ): 0.031 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.044 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.046 ): -0.004 KiB JetMET/SUSYDQM
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: found differences in 3 / 42 workflows

[jfernan2]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa804a/42291/summary.html
COMMIT: e5974fc
CMSSW: CMSSW_14_2_X_2024-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46429/42291/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3566331
• DQMHistoTests: Total failures: 416
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565895
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 201 log files, 171 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1