Skip to content

Update new timing seeds for HI #46462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

JunseokLee3609
Copy link
Contributor

PR description:

  • There is an issue with the DQM timing plot not being properly drawn during the HI run (DQMGUI, Run 375703, Plots 19-22)
  • Change the L1 seeds used for drawing the timing plot to L1 seeds that correspond to the 50 ns bunch spacing of the HI run

@cmsbuild cmsbuild changed the base branch from CMSSW_14_2_X to master October 21, 2024 11:47
@cmsbuild
Copy link
Contributor

@JunseokLee3609, CMSSW_14_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46462/42323

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @JunseokLee3609 for master.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8edd18/42332/summary.html
COMMIT: 1b46a41
CMSSW: CMSSW_14_2_X_2024-10-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46462/42332/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 463
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565848
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

  • P5 tests successful

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovagnerini
Copy link

@JunseokLee3609 could you also provide the backport of this PR to 14.1.X as that is the HI target release?

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 71f2381 into cms-sw:master Oct 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants