Draft: Add Giovanna's PFA as an option for vertex simulation #47020
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43131 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43351 |
|
Pull request #47020 was updated. |
…ction and add option not to apply width SF for weighted-average z0 computation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43438 |
|
Pull request #47020 was updated. |
| } | ||
|
|
||
| float GaussianWidth = settings_->vx_pfa_etadependentresolution() | ||
| ? 0.09867 + 0.0007 * trackAbsEta + 0.0587 * trackAbsEta * trackAbsEta |
There was a problem hiding this comment.
What are these numbers? A comment here would be useful to anyone doing maintenance later.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43540 |
|
Pull request #47020 was updated. |
|
Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X. |
…documented) WeightedZ0 options for testing purposes.
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43838 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43840 |
|
Pull request #47020 was updated. |
…ng step functon PFA weights) that can be implemented with minimal changes to the existing FH code.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47020/43846 |
|
Pull request #47020 was updated. |
Draft for internal review in the GTT group.
Some of the code was only for testing purposes. It simplifies a lot if
settings_->vx_nvtx()=1is now the default (can useVertexFinder::PFASingleVertex()instead ofVertexFinder::PFA()in that case).Depending on the above, it may also make more sense to modify the original
computeAndSetVertexParametersfunction rather than making a newcomputeAndSetVertexParametersPFA, since the two have a lot in common.