L1 tracking update #47067
Open
L1 tracking update #47067
+15,907
−13,017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43234
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
new-package-pending
code-checks-rejected
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43235
|
tschuh
force-pushed
the
L1TK-PR-14_2_0_pre4
branch
from
94ae2d7 to
e2dc5ef
Compare
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43238
|
tschuh
force-pushed
the
L1TK-PR-14_2_0_pre4
branch
from
e2dc5ef to
a5f36b2
Compare
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
cmsbuild
added
operations-pending
tests-pending
code-checks-pending
and removed
operations-approved
tests-approved
code-checks-approved
labels
done for the code I feel responsible for. |
I copy pasted the comment explaining those 2-3 character names from KalmanFilter.h to this place. |
I moved the explaining comment from the top to the middle, hope that helps |
done |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/44540
|
|
Pull request #47067 was updated. @BenjaminRS, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @quinnanm, @rappoccio, @srimanob, @subirsarkar can you please check and sign again. |
I did go through my code, hope I got them all. |
Those classes do not specify data types of ED products. I doubt that they should go to the DataFormats module. |
yes now I have done them, before I had to rebase. |
quinnanm
reviewed
Apr 19, 2025
| const std::vector<int>& layerEncoding(int binEta, int binZT, int binCot) const { | ||
| return layerEncoding_.layerEncoding(binEta, binZT, binCot); | ||
| const std::vector<int> layerEncoding(int binEta, int binZT, int binCot) const { | ||
| //return layerEncoding_.layerEncoding(binEta, binZT, binCot); |
There was a problem hiding this comment.
cam you get rid of these comments if unneeded
| const std::map<int, const tt::SensorModule*>& layerEncodingMap(int binEta, int binZT, int binCot) const { | ||
| return layerEncoding_.layerEncodingMap(binEta, binZT, binCot); | ||
| const std::map<int, const tt::SensorModule*> layerEncodingMap(int binEta, int binZT, int binCot) const { | ||
| //return layerEncoding_.layerEncodingMap(binEta, binZT, binCot); |
There was a problem hiding this comment.
cam you get rid of these comments if unneeded
Comment on lines
35
to
39
| static constexpr int partial_width = 32; | ||
| // | ||
| static constexpr int partial_in = 3; | ||
| // | ||
| static constexpr int partial_out = 2; |
There was a problem hiding this comment.
please add comments describing where these numbers come from
| @@ -30,4 +28,44 @@ def reducedConfig(process): | |||
|
|
|||
| # configures pure tracklet algorithm (as opposed to Hybrid algorithm) | |||
| def trackletConfig(process): | |||
| process.l1tTTTracksFromTrackletEmulation.fitPatternFile = cms.FileInPath('L1Trigger/TrackFindingTracklet/data/fitpattern.txt') | |||
| process.l1tTTTracksFromTrackletEmulation.fitPatternFile = cms.FileInPath('L1Trigger/TrackFindingTracklet/data/fitpattern.txt') | |||
There was a problem hiding this comment.
is this the best place for such txt files or is there a better place to put them?
There was a problem hiding this comment.
I don't know, @tomalin may comment.
Comment on lines
35
to
71
| process.ProducerKF.Hybrid = True | ||
| process.ProducerKF.DeadModuleOpts.KillScenario = 0 | ||
| process.ProducerKF.DeadModuleOpts.KillRecover = False | ||
| process.ProducerKF.HTArraySpecRphi.HoughMinPt = 2. | ||
| process.ProducerKF.TrackDigi.KF_skipTrackDigi = True | ||
| process.ProducerKF.StubDigitize.EnableDigitize = False | ||
| process.ProducerKF.GeometricProc.UseApproxB = True | ||
| process.ProducerKF.GeometricProc.BApprox_gradient = 0.886454 | ||
| process.ProducerKF.GeometricProc.BApprox_intercept = 0.504148 | ||
| process.ProducerKF.PhiSectors.NumPhiSectors = 9 | ||
| process.ProducerKF.PhiSectors.NumPhiNonants = 9 | ||
| process.ProducerKF.PhiSectors.ChosenRofPhi = 55. | ||
| process.ProducerKF.EtaSectors.EtaRegions = [-2.4, -2.08, -1.68, -1.26, -0.90, -0.62, -0.41, -0.20, 0.0, 0.20, 0.41, 0.62, 0.90, 1.26, 1.68, 2.08, 2.4] | ||
| process.ProducerKF.EtaSectors.ChosenRofZ = 50.0 | ||
| process.ProducerKF.TrackFitSettings.KalmanMinNumStubs = 4 | ||
| process.ProducerKF.TrackFitSettings.KalmanMaxNumStubs = 6 | ||
| process.ProducerKF.TrackFitSettings.KalmanMaxSkipLayersHard = 1 | ||
| process.ProducerKF.TrackFitSettings.KalmanMaxSkipLayersEasy = 2 | ||
| process.ProducerKF.TrackFitSettings.KalmanMaxStubsEasy = 10 | ||
| process.ProducerKF.TrackFitSettings.KalmanMaxStubsPerLayer = 4 | ||
| process.ProducerKF.TrackFitSettings.KalmanMultiScattTerm = 0.00075 | ||
| process.ProducerKF.TrackFitSettings.KalmanChi2RphiScale = 8 | ||
| process.ProducerKF.TrackFitSettings.KFUseMaybeLayers = True | ||
| process.ProducerKF.TrackFitSettings.KalmanRemove2PScut = True | ||
| process.ProducerKF.TrackFitSettings.KFLayerVsPtToler = [999., 999., 0.1, 0.1, 0.05, 0.05, 0.05] | ||
| process.ProducerKF.TrackFitSettings.KFLayerVsD0Cut5 = [999., 999., 999., 10., 10., 10., 10.] | ||
| process.ProducerKF.TrackFitSettings.KFLayerVsZ0Cut5 = [999., 999., 25.5, 25.5, 25.5, 25.5, 25.5] | ||
| process.ProducerKF.TrackFitSettings.KFLayerVsZ0Cut4 = [999., 999., 15., 15., 15., 15., 15.] | ||
| process.ProducerKF.TrackFitSettings.KFLayerVsChiSq5 = [999., 999., 10., 30., 80., 120., 160.] | ||
| process.ProducerKF.TrackFitSettings.KFLayerVsChiSq4 = [999., 999., 10., 30., 80., 120., 160.] | ||
| process.ProducerKF.TrackFitSettings.KalmanAddBeamConstr = False | ||
| process.ProducerKF.TrackFitSettings.KalmanHOfw = False | ||
| process.ProducerKF.TrackFitSettings.KalmanHOtilted = True | ||
| process.ProducerKF.TrackFitSettings.KalmanHOprojZcorr = 1 | ||
| process.ProducerKF.TrackFitSettings.KalmanHOalpha = 0 | ||
| process.ProducerKF.TrackFitSettings.KalmanHOhelixExp = True | ||
| process.ProducerKF.TrackFitSettings.KalmanDebugLevel = 0 |
There was a problem hiding this comment.
please add some comments explaining where these numbers come from
| @@ -42,5 +42,4 @@ | |||
| # We prefer the global geometry algorithm for now in order not to break | |||
| # anything. Override with process.TTStubAlgorithm_PSimHit_ = ..., | |||
| # etc. in your configuration. | |||
| TTStubAlgorithm_Phase2TrackerDigi_ = cms.ESPrefer("TTStubAlgorithm_official_Phase2TrackerDigi_") | |||
|
|
|||
| TTStubAlgorithm_Phase2TrackerDigi_ = cms.ESPrefer("TTStubAlgorithm_official_Phase2TrackerDigi_") | |||
There was a problem hiding this comment.
add empty line at end of file
L1Trigger/TrackTrigger/src/Setup.cc
Outdated
| return trackerGeometry_->getDetectorType(detId) == TrackerGeometry::ModuleType::Ph2PSP; | ||
| SensorModule* sm = sensorModule(detId + 1); | ||
| return sm->psModule(); | ||
| //return trackerGeometry_->getDetectorType(detId) == TrackerGeometry::ModuleType::Ph2PSP; |
There was a problem hiding this comment.
is there a reason to keep this comment? otherwise delete
Comment on lines
7
to
21
| process.TrackTriggerSetup.UseHybrid = False | ||
| process.TrackTriggerSetup.TrackFinding.MinPt = 3.0 | ||
| process.TrackTriggerSetup.TrackFinding.MaxEta = 2.4 | ||
| process.TrackTriggerSetup.TrackFinding.ChosenRofPhi = 67.24 | ||
| process.ProducerDTC = cms.EDProducer('trackerDTC::ProducerDTC', TrackerDTC_params) | ||
| return process | ||
|
|
||
| def analyzerUseTMTT(process): | ||
| from L1Trigger.TrackerDTC.Analyzer_cfi import TrackerDTCAnalyzer_params | ||
| from L1Trigger.TrackerDTC.ProducerED_cfi import TrackerDTCProducer_params | ||
| TrackerDTCProducer_params.UseHybrid = cms.bool( False ) | ||
| process.TrackerDTCAnalyzer = cms.EDAnalyzer('trackerDTC::Analyzer', TrackerDTCAnalyzer_params, TrackerDTCProducer_params) | ||
| from L1Trigger.TrackerDTC.DTC_cfi import TrackerDTC_params | ||
| process.TrackTriggerSetup.UseHybrid = False | ||
| process.TrackTriggerSetup.TrackFinding.MinPt = 3.0 | ||
| process.TrackTriggerSetup.TrackFinding.MaxEta = 2.4 | ||
| process.TrackTriggerSetup.TrackFinding.ChosenRofPhi = 67.24 | ||
| process.AnalyzerDTC = cms.EDAnalyzer('trackerDTC::Analyzer', TrackerDTCAnalyzer_params, TrackerDTC_params) |
There was a problem hiding this comment.
could you add some context to these numbers?
Comment on lines
32
to
36
| static constexpr int partial_width = 32; | ||
| // | ||
| static constexpr int partial_in = 3; | ||
| // | ||
| static constexpr int partial_out = 2; |
There was a problem hiding this comment.
could you add context to these numbers
Comment on lines
6
to
25
| process.TrackTriggerSetup.TMTT.WidthR = 11 | ||
| process.TrackTriggerSetup.TMTT.WidthPhi = 14 | ||
| process.TrackTriggerSetup.TMTT.WidthZ = 13 | ||
| process.TrackTriggerSetup.TrackFinding.MinPt = 3.0 | ||
| process.TrackTriggerSetup.TrackFinding.MaxEta = 2.4 | ||
| process.TrackTriggerSetup.TrackFinding.ChosenRofPhi = 67.24 | ||
| process.TrackTriggerSetup.TrackFinding.NumLayers = 8 | ||
| process.TrackTriggerSetup.GeometricProcessor.ChosenRofZ = 57.76 | ||
| process.TrackTriggerSetup.HoughTransform.MinLayers = 5 | ||
| process.TrackTriggerSetup.CleanTrackBuilder.MaxStubs = 4 | ||
| process.TrackTriggerSetup.KalmanFilter.NumWorker = 4 | ||
| process.TrackTriggerSetup.KalmanFilter.MaxLayers = 8 | ||
| process.TrackTriggerSetup.KalmanFilter.MaxSeedingLayer = 3 | ||
| process.TrackTriggerSetup.KalmanFilter.MaxGaps = 2 | ||
| process.TrackTriggerSetup.KalmanFilter.ShiftChi20 = 0 | ||
| process.TrackTriggerSetup.KalmanFilter.ShiftChi21 = 0 | ||
| process.TrackTriggerSetup.KalmanFilter.CutChi2 = 2.0 | ||
|
|
||
| def simUseTMTT(process): | ||
| process.StubAssociator.MinPt = 3.0 |
There was a problem hiding this comment.
please add context to these numbers
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/44582
|
|
Pull request #47067 was updated. @BenjaminRS, @Moanwar, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @quinnanm, @rappoccio, @srimanob, @subirsarkar can you please check and sign again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mainly the modules
in order to sync s/w emulation of L1 tracking with current f/w, which means to make the s/w more realistic. Some name changes have also been propagated to additional modules.
some specific added features:
This PR is based of CMSSW_14_2_0_pre4 rebased to master on Jan 9.
The code in this PR passed the git CI tests of the L1 track group, seen in the CI results. The git CI tests run the baseline L1 tracking algorithm (both for prompt and displaced tracking) on ttbar events with zero pileup (to save CPU). The CI checks require that compared with reference, the tracking efficiency does not fall significantly, the number of reconstructed tracks does not increase significantly, and that the z0 resolution does not get significantly worse. (The exact cuts can be found here).