L1 tracking update #47067
Merged
L1 tracking update #47067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43234
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
new-package-pending
code-checks-rejected
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43235
|
tschuh
force-pushed
the
L1TK-PR-14_2_0_pre4
branch
from
94ae2d7 to
e2dc5ef
Compare
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47067/43238
|
tschuh
force-pushed
the
L1TK-PR-14_2_0_pre4
branch
from
e2dc5ef to
a5f36b2
Compare
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@tschuh , there are many relvals failing in IBs with error [a] . Looks like the change here is triggering these failures. Can you please look in to it and provide a fix? [a] |
|
I had a look and struggle to reproduce the error. Looks like it is a feature for CMSSW_13_2_0_pre1 samples using a Geometry (Extended2026) which doesn't exist anymore. I can't run this sample with CMSSW_15_1_X therefore, but I am also getting compilation errors when I try to compile this branch in CMSSW_13_2_0. |
|
Looks for me however that we have again a case where the workflow tests L1 tracking with unsupported configuration. In the past I did detect such cases inside my EDProducers and let the produce function immediately return without executing the tracking. I found it however to be too cumbersome to maintain this detection of valid configurations. Is it possible to tune the tests to not run the tracking when it is too outdated? |
The files are available in the IB EOS cache. E.g. on lxplus run
I suppose this question would be for @cms-sw/upgrade-l2. |
|
So I did run which looks good to me, what am I doing wrong? |
|
The problem doesn't happen consistently. E.g. in the 2025-06-02-2300 IB 24834.0 did not fail but |
|
Could this be a threading problem then? Repeating the step 2 with e.g. 4 threads some number of times could hopefully reproduce the problem. |
Thread-related is my guess (I've also been puzzling over the non-replicability), so not surprised that a single threaded test fails to reproduce the failure. |
|
I see. To explain the error thrown: during tracking emulation we request to put a variable in a binary with negative number of bits, which is nonsense. The bit widths are calculated in an ESProduct (called trackerTFP::Dataformats). |
|
Exception seen in a UBSAN build WF 34434.0 step2, with some possibly helpful UBSAN runtime errors. The first two look like an negative array index (UBSAN hits also have the virtue of line numbers): |
|
Another possibly relevant UBSAN hit preceding the others in the previous comment: |
|
ah. I see that we dropped the init of useHybrid_ in tt::Setup by accident. Shall I push a commit to this branch or create a new PR with a fix for that? |
|
You need to make a new PR to fix it (nothing can be done here after the merge). |
|
I created this PR #48247 which should get rid of the UBSAN runtime errors pointed by Dan. |
Merged
|
Looks like the uninitiated variable was the problem. Am I seeing it correct that there no further outstanding issues? |
|
Great, many thanks for the hints and help and sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mainly the modules
in order to sync s/w emulation of L1 tracking with current f/w, which means to make the s/w more realistic. Some name changes have also been propagated to additional modules.
some specific added features:
This PR is based of CMSSW_14_2_0_pre4 rebased to master on Jan 9.
The code in this PR passed the git CI tests of the L1 track group, seen in the CI results. The git CI tests run the baseline L1 tracking algorithm (both for prompt and displaced tracking) on ttbar events with zero pileup (to save CPU). The CI checks require that compared with reference, the tracking efficiency does not fall significantly, the number of reconstructed tracks does not increase significantly, and that the z0 resolution does not get significantly worse. (The exact cuts can be found here).