Skip to content

Fix cfi creation for conf db parsing #47156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 21, 2025

PR description:

@Martin-Grunewald reported an issue in the confDB parsing of CMSSW_15_0_0_pre2 concerning:

 -> hltBcJpsiTkAllConeTracksIter [ConcreteChargedCandidateProducer] CHANGED
       string particleType = "K+" [REMOVED]
  -> hltCscSegments [CSCSegmentProducer] CHANGED
       VPSet algo_psets [REMOVED]

this is due to #47017 and #47045 having the modules ConcreteChargedCandidateProducer and CSCSegmentProducer auto-generate cfi files with incomplete top level parameter configurations.
This PR fixes the issue

PR validation:

Upon compilation I get the following python files available:

$ more ../cfipython/el9_amd64_gcc12/CommonTools/RecoAlgos/ConcreteChargedCandidateProducer.py
import FWCore.ParameterSet.Config as cms

def ConcreteChargedCandidateProducer(*args, **kwargs):
  mod = cms.EDProducer('ConcreteChargedCandidateProducer',
    src = cms.InputTag(''),
    particleType = cms.string('pi+'),
    mightGet = cms.optional.untracked.vstring
  )
  for a in args:
    mod.update_(a)
  mod.update_(kwargs)
  return mod

and

$ more ../cfipython/el9_amd64_gcc12/RecoLocalMuon/CSCSegment/CSCSegmentProducer.py                                                                                                   import FWCore.ParameterSet.Config as cms

def CSCSegmentProducer(*args, **kwargs):
  mod = cms.EDProducer('CSCSegmentProducer',
    inputObjects = cms.InputTag('csc2DRecHits'),
    algo_type = cms.int32(5),
    algo_psets = cms.VPSet(
    ),
    mightGet = cms.optional.untracked.vstring
  )
  for a in args:
    mod.update_(a)
  mod.update_(kwargs)
  return mod

which is fine for parsing purposes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Jan 21, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 21, 2025

urgent

  • must be included in the next pre-release

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • RecoLocalMuon/CSCSegment (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@abbiendi, @ahinzmann, @bellan, @gkasieczka, @hatakeyamak, @jdolen, @jhgoh, @missirol, @ptcox, @rappoccio this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 21, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7237bc/43892/summary.html
COMMIT: 7da557d
CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47156/43892/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 65
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3819000
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5f5d53a into cms-sw:master Jan 21, 2025
11 checks passed
@mmusich mmusich deleted the fix_cfi_forConfDB branch January 21, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants