-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Run3-gex186B Modify all Run3 scenarios to include the modified RPC geometry #47159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47159/43390 |
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 52KB to repository Comparison SummarySummary:
|
+geometry |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
To be tested with #47138 |
hold |
Pull request has been put on hold by @mandrenguyen |
RPC geometry has a major bug correction which is addressed in #47139. This also demands all RPC-related XML files to be corrected. There are 3 such groups related to Run2, Run3 and Run4 for which 3 PRs have been posted. One needs to merge all 4 PRs and then we need to update the DB. We realized a problem when we tried to make 2024 geometry but this was by-passed. It is better to have the correct code and the corresponding XML files now. Merging the PRs for Run2 (#47158) and Run3 (#47159) will not create an issue because we have not yet modified the geometries in DB.
…________________________________
From: cmsbuild ***@***.***>
Sent: 23 January 2025 13:40
To: cms-sw/cmssw ***@***.***>
Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***>
Subject: Re: [cms-sw/cmssw] Run3-gex186B Modify all Run3 scenarios to include the modified RPC geometry (PR #47159)
Pull request has been put on hold by @mandrenguyen<https://github.com/mandrenguyen>
They need to issue an unhold command to remove the hold state or L1 can unhold it for all
—
Reply to this email directly, view it on GitHub<#47159 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOU3NDEAXKZR3FEEKNT2MCPZHAVCNFSM6AAAAABVUF5KRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBZGEYTKNRXGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Modify all Run3 scenarios to include the modified RPC geometry
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special