[GEM] Turning on the applyMasking flag for Run 3 GEM data taking

[yeckang]

PR description:

• GEM strip masking was started in the middle of 2023 to avoid a high trigger rate which is caused by noisy channels
• This PR enables clustering by considering the strip masking on the local reconstruction of GEM.
• The PR couldn't be made because no GEMDeadSrtripsRcd and GEMMaskedStripsRcd existed in any global tag.
• The GEMDeadStripsRcd and GEMMaskedStripsRcd have been on the condDB recently.
• At the moment, the GEMDeadStripsRcd and GEMMaskedStripsRcd are empty. So we don't expect any changes in the result.

PR validation:

• The scram b code-format and scram b code-checks are applied.
• The runTheMatrix.py -w standard -l 145.006 is performed for the test. The scenario using the Run3 data which is this PR affecting.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47257/43553

[cmsbuild]

A new Pull Request was created by @yeckang for master.

It involves the following packages:

• RecoLocalMuon/GEMRecHit (upgrade, reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bellan, @jhgoh, @jshlee, @missirol, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01f41a/44188/summary.html
COMMIT: 6180524
CMSSW: CMSSW_15_0_X_2025-02-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47257/44188/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS

RelVals

• 29634.75

----- Begin Fatal Exception 04-Feb-2025 19:16:23 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module GEMRecHitProducer/'gemRecHits'
Exception Message:
No "GEMMaskedStripsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

• 29834.999

----- Begin Fatal Exception 04-Feb-2025 19:20:56 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module GEMRecHitProducer/'gemRecHits'
Exception Message:
No "GEMMaskedStripsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

• 24834.911

----- Begin Fatal Exception 04-Feb-2025 19:24:25 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module GEMRecHitProducer/'gemRecHits'
Exception Message:
No "GEMMaskedStripsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 312.0
• 29700.0
• 12434.0
• 29696.0
• 11634.0
• 29634.911
• 29634.0

AddOn Tests

• hlt_mc_HIon

----- Begin Fatal Exception 04-Feb-2025 18:59:07 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 1
   [1] Calling method for module GEMRecHitProducer/'gemRecHits'
Exception Message:
No "GEMMaskedStripsRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

[mmusich]

FYI @cms-sw/alca-l2 looks like some GTs to be updated were missed (e.g. HIon MC, phase-2)

[watson-ij]

FYI @cms-sw/alca-l2 looks like some GTs to be updated were missed (e.g. HIon MC, phase-2)

@yeckang probably we don't need this in phase 2, can we just turn off masking in the phase2 modify line?

[perrotta]

FYI @cms-sw/alca-l2 looks like some GTs to be updated were missed (e.g. HIon MC, phase-2)

@yeckang probably we don't need this in phase 2, can we just turn off masking in the phase2 modify line?

I will prepare the modified GTs with the dedicated tags nonetheless

[yeckang]

I thought that the applyMasking flag should be false if I don't make a modifier. But it does not work the way I thought. I will push the new commit with the modifier for phase 2. I don't plan to turn on the flag for phase 2.
And I will contact AlCa to include the tags for HIon.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47257/43576

[perrotta]

Great, tests succeed!
2025 GTs already contain all needed features.
There are no differences in the test outputs because currently there are not masked channels in GEM in those payloads.

[jfernan2]

+1
@perrotta I understand this is ready to go then, I have not assigned to alca-db this PR, but feel free to autoassign if you consider it. Thanks

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

assign alca

[cmsbuild]

New categories assigned: alca

@atpathak,@consuegs,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[missirol]

@yeckang

Does this update need to be backported to CMSSW_15_0_X ?

[missirol]

@yeckang

Does this update need to be backported to CMSSW_15_0_X ?

Tagging @cms-sw/reconstruction-l2 and @cms-sw/alca-l2 before I forget this.

This change has been applied to the Run-3 HLT menus for 2025 in CMSHLT-3420.

[perrotta]

@yeckang
Does this update need to be backported to CMSSW_15_0_X ?

Tagging @cms-sw/reconstruction-l2 and @cms-sw/alca-l2 before I forget this.

This change has been applied to the Run-3 HLT menus for 2025 in CMSHLT-3420.

... and the 150X online GTs are ready for it! This PR does not affect the possibility to implement it in the HLT menu. Of course, if GEM wants to have the possibility to mask or declare as dead some channels also in reco, @yeckang (or someone else from the GEM group) should take care of backporting this PR in 150X.