New constructor for the SoAView and aggregate method for Collections #47306
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47306/43631 |
|
A new Pull Request was created by @leobeltra for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
type ngt |
cmsbuild
added
ngt
tests-pending
code-checks-pending
and removed
tests-started
code-checks-approved
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47306/43632 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47306/43633 |
| REQUIRE(genericCollection.view().metadata().addressOf_candidateDirection() != | ||
| pcaCollectionView.metadata().addressOf_candidateDirection()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing newline at the end of file :(
|
|
||
| // fill up | ||
| for (size_t i = 0; i < elems; i++) { | ||
| positionCollectionView[i] = {i * 1.f, i * 2.0f, i * 3.0f}; |
There was a problem hiding this comment.
Pedantic: could you use either 1.0f, 2.0f, ... or 1.f, 2.f, ... consistently ?
There was a problem hiding this comment.
Some strange has happened to this file.
Did you clang-format it ?
leobeltra
force-pushed
the
PR_view_constructor
branch
from
1bb9b54 to
6f85fb2
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47306/44376
|
|
please test |
|
+heterogeneous |
cmsbuild
added
fully-signed
tests-started
heterogeneous-approved
and removed
pending-signatures
tests-pending
heterogeneous-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 44KB to repository Comparison SummarySummary:
|
|
+1 |
PR description:
Added a new constructor for the
SoAViewtaking as input columns from differentViews and putting them in a single object. A run-time check on the column sizes being the same is performed.Additionally, a new
aggregatemethod has been added toPortableHostCollectiontaking as input aSoAViewand creating a unique memory buffer to save its columns contiguously. This is useful to create a PortableCollection from the VIew built with the newly implemented constructor.Unit tests for both these features have been added as well.
PR validation:
Unit tests created pass.