Skip to content

[15.0.X] fix customizeHLTfor47047 to work also on menus already customized #47395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 18, 2025

backport of #47393

PR description:

Title says it all, addresses discussion at #47047 (comment) .

PR validation:

Passes addOnTests.py.
Tested on a 15_0_X based menu (after re-absorbing customization functions) with:

#!/bin/bash -ex

hltGetConfiguration /dev/CMSSW_15_0_0/GRun/V5 \
   --globaltag 142X_mcRun3_2025_realistic_v4 \
   --mc \
   --unprescale \
   --output minimal \
   --max-events 100 \
   --input /store/mc/Run3Winter25Digi/TT_TuneCP5_13p6TeV_powheg-pythia8/GEN-SIM-RAW/142X_mcRun3_2025_realistic_v7-v2/130000/eaf68a23-673f-48fa-a912-92097c37bd14.root  \
   --eras Run3_2025 --l1-emulator uGT --l1 L1Menu_Collisions2024_v1_3_0_xml \
   > hltMC.py

cmsRun hltMC.py >& hltMC.log

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatimb backport of #47393 to CMSSW_15_0_X

@mmusich
Copy link
Contributor Author

mmusich commented Feb 18, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 18, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff76da/44495/summary.html
COMMIT: e6c3a91
CMSSW: CMSSW_15_0_X_2025-02-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47395/44495/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4019507
  • DQMHistoTests: Total failures: 56
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4019431
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 19, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a3770dd into cms-sw:CMSSW_15_0_X Feb 20, 2025
9 checks passed
@mmusich mmusich deleted the fix_customizeHLTfor47047_15_0_x branch February 20, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants