-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[RFC] Avoid passing LD_PRELOAD to rocmIsEnabled subprocess #47452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47452/43874 |
enable gpu |
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
I understand that this is supposed to work around #47450, but it could also break the case where Anyway, if this is needed, I would make the same changes for |
PR description:
Should work around the problem in #47450
Resolves cms-sw/framework-team#1269
PR validation:
Added printouts around
p.communicate()
and rancmsRun
withLD_PRELOAD=libPerfToolsAllocMonitorPreload.so:libPerfToolsMaxMemoryPreload.so
. WithLD_PRELOAD
included in the environment, saw the MaxMemoryPreload printouts fromrocmIsEnabled
, and withLD_PRELOAD
excluded (as in this PR), the MaxMemoryPreload printouts disappeared.