BPHNanoAODs

[gmelachr]

Following the presentation in the xPOG meeting (https://indico.cern.ch/event/1509026/#2-bph-custom-nanoaod), this is the PR for the BPH-flavor nanoAODs.

FYI: @drkovalskyi @gkaratha @hqucms @ftorrresd

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[vlimant]

assign xpog

[vlimant]

please include how this would be ran within a cmsDriver command ; and this will likely require the --step NANO:@BPH to be implemented.

[ftorrresd]

enable nano

[ftorrresd]

please test

[ftorrresd]

Hi @gmelachr -- as a follow-up on Jean-Roch's comment, usually NanoAOD flavors implement their customizations and make them related to a new sequence at autoNANO.py

https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/autoNANO.py

[makortel]

The binary files should be placed in a (new?) repository in https://github.com/cms-data/

[makortel]

This is a wrong package to define dictionaries for persistable data products (see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts#Restrictions_on_the_package_defi).

[makortel]

Dictionaries for reco::TransientTrack must be defined in the package that defines the class, i.e. TrackingTools/TransientTrack. Given that that package is a non-DataFormat package, the dictionary for Wrapper must be declared as transient along

 <class name="edm::Wrapper<std::vector<reco::TransientTrack> >" persistent="false"/>

The dictionary for std::vector<reco::TransientTrack> should not specify class version (because it is an instantiation of a class template).

[makortel]

If dictionary for KinVtxFitter is needed, the Wrapper must be declared as transient

 <class name="edm::Wrapper<std::vector<KinVtxFitter> >" persistent="false"/>

However, it seems not to be put into the edm::Event in the present form of this PR (I only saw commented-out code). If it is not necessary to put it into edm::Event, I'd suggest to remove that commented-out code and these dictionary declarations.

[makortel]

These dictionaries must go to the package that defines pat::CompositeCandidateCollection, i.e. DataFormats/PatCandidates.

[makortel]

This dummy struct is not needed (since long time).

Suggested change

	namespace {
	struct dictionary {
	std::vector<reco::TransientTrack> ttv;
	edm::Wrapper<std::vector<reco::TransientTrack> > wttv;
	edm::Wrapper<std::vector<KinVtxFitter> > wkv;
	};
	}

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Custom Phase-2 L1 Trigger NanoAOD #47178, Add era modifiers for ScoutingNano to account for changes in 2022-24 and beginning of 2025 #47302

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[gmelachr]

Hi @gmelachr -- as a follow-up on Jean-Roch's comment, usually NanoAOD flavors implement their customizations and make them related to a new sequence at autoNANO.py

https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/autoNANO.py

Hello, the BPH-flavor has been added in the autoNANO.py

@ftorrresd @vlimant The cmsDriver command is:

cmsDriver.py --conditions 140X_dataRun3_Prompt_v4 --datatier NANOAOD --era Run3,run3_nanoAOD_pre142X --eventcontent NANOAOD --filein root://cms-xrd-global.cern.ch//store/data/Run2024C/ParkingDoubleMuonLowMass0/MINIAOD/PromptReco-v1/000/379/415/00000/b40397b5-61c6-4887-8f4e-025e8ca925ee.root --fileout file:/tmp/gmelachr/BPH_test_data.root --nThreads 4 -n -1 --no_exec --python_filename BPH_test.py --scenario pp --step NANO:@bph

@makortel 's comments are work in progress

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039

• There are other open Pull requests which might conflict with changes you have proposed:
  • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Custom Phase-2 L1 Trigger NanoAOD #47178, Add era modifiers for ScoutingNano to account for changes in 2022-24 and beginning of 2025 #47302

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[gmelachr]

The review of the PR continues at #47603