Skip to content

Lowered cluster charge threshold for pixel L1 #47480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ferencek
Copy link
Contributor

PR description:

This PR lowers the cluster charge threshold in pixel layer 1 from 4000 to 2000 electrons for era Run3_2025. The change is motivated by results presented in https://indico.cern.ch/event/1492109/#118-radiation-damage-projectio during the January 2025 Tracker Week. While the mentioned change is undergoing TSG and the tracking POG validation, this PR is being created to already start its validation. More info about the ongoing validation will be added here as it become available.

PR validation:

Only configuration-level changes so made sure that scram b works and checked that the correct changes are picked up in the following example cmsDriver commands

cmsDriver.py SingleMuPt10_pythia8_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW,RAW2DIGI,RECO --python_filename=test_2025.py -n 100 --no_exec --era Run3_2025 --nThreads=4 --conditions auto:phase1_2024_realistic

cmsDriver.py SingleMuPt10_pythia8_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW,RAW2DIGI,RECO --python_filename=test_Alpaka_2025.py -n 100 --no_exec --era Run3_2025 --nThreads=4 --conditions auto:phase1_2024_realistic --procModifiers alpaka

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to CMSSW_15_0_X for 2025 data taking will be needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47480/43926

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @makortel, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@ferencek
Copy link
Contributor Author

I wasn't sure if run3_SiPixel_2025 should also be added to Configuration/StandardSequences/python/Eras.py

@mmusich
Copy link
Contributor

mmusich commented Mar 4, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Mar 4, 2025

I wasn't sure if run3_SiPixel_2025 should also be added to Configuration/StandardSequences/python/Eras.py

I think you should.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47480/43946

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2025

Pull request #47480 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @mandrenguyen, @rappoccio can you please check and sign again.

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 4, 2025

enable profiling

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 4, 2025

please test

@ferencek
Copy link
Contributor Author

hold @ferencek looks like a conflict popped up. Can you have a look please?

Rebased to CMSSW_15_1_X_2025-03-14-1100. Should be ok now.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47480/44096

@cmsbuild
Copy link
Contributor

Pull request #47480 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @kskovpen, @mandrenguyen, @mmasciov, @rappoccio can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Mar 17, 2025

@cms-sw/tracking-pog-l2 please sign again
@mandrenguyen please unhold

@mandrenguyen
Copy link
Contributor

unhold
thanks for the ping @mmusich

@cmsbuild cmsbuild removed the hold label Mar 17, 2025
@mmasciov
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e411fd/44998/summary.html
COMMIT: 60ff529
CMSSW: CMSSW_15_1_X_2025-03-16-2300/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47480/44998/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 887c97d into cms-sw:master Mar 17, 2025
13 checks passed
@ferencek ferencek deleted the LoweredSiPixelL1ClusterThreshold_from-CMSSW_15_1_X_2025-02-28-1100 branch March 18, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants