-
Notifications
You must be signed in to change notification settings - Fork 4.4k
remove L1T legacy dependencies from pixel and strip online DQM clients #47508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove L1T legacy dependencies from pixel and strip online DQM clients #47508
Conversation
type bug-fix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47508/43963
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
ping @cms-sw/dqm-l2 (here and in the backports) |
+dqm
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a follow-up to #46716 and fixes a couple of leftovers in the Pixel and SiStrip DQM clients that are crashing now after the deletion of legacy L1T records at https://its.cern.ch/jira/browse/CMSALCAFAST-94 with:
This is circumvented by using where appropriate the
stage2L1Trigger
modifier.PR validation:
runs fine in this branch.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported to CMSSW_14_2_X for 2025 data-taking operations.
cc: @nothingface0