Skip to content

remove L1T legacy dependencies from pixel and strip online DQM clients #47508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 5, 2025

PR description:

This is a follow-up to #46716 and fixes a couple of leftovers in the Pixel and SiStrip DQM clients that are crashing now after the deletion of legacy L1T records at https://its.cern.ch/jira/browse/CMSALCAFAST-94 with:

----- Begin Fatal Exception 05-Mar-2025 10:36:43 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 387552 lumi: 1 event: 350 stream: 0
   [1] Running path 'p'
   [2] Calling method for module L1GlobalTriggerRawToDigi/'gtDigis'
Exception Message:
No "L1MuTriggerScalesRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

This is circumvented by using where appropriate the stage2L1Trigger modifier.

PR validation:

setenv CMS_PATH "/cvmfs/cms-ib.cern.ch"
setenv SITECONFIG_PATH "/cvmfs/cms-ib.cern.ch/SITECONF/local"
cd DQM/Integration/python/clients
mkdir upload
cmsRun sistrip_dqm_sourceclient-live_cfg.py unitTest=True
cmsRun pixel_dqm_sourceclient-live_cfg.py unitTest=True runkey=cosmic_run

runs fine in this branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_14_2_X for 2025 data-taking operations.

cc: @nothingface0

@mmusich
Copy link
Contributor Author

mmusich commented Mar 5, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47508/43963

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 5, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f02842/44815/summary.html
COMMIT: 2dcb380
CMSSW: CMSSW_15_1_X_2025-03-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47508/44815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920219
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Mar 6, 2025

ping @cms-sw/dqm-l2 (here and in the backports)

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7772e45 into cms-sw:master Mar 7, 2025
11 checks passed
@mmusich mmusich deleted the mm_dev_fix_L1Tstage1Dependencies_follow_up branch March 7, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants