add fillDescriptions to several BTV plugins used at HLT

[SWuchterl]

PR description:

This PR is similar in spirit to #47017, #47045, #47079, #47107, #47136, #47191, and #47224. It adds fillDescriptions (and applies light modification to modernize the source code) to a few EDProducers used at HLT for both Run 3 and Phase 2 used (among others) by the BTV POG.

See also this issue: #47275.

PR validation:

• runTheMatrix.py -l limited runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47513/43970

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoBTag/Combined/plugins/BTagProbabilityToDiscriminator.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/ImpactParameter/plugins/IPProducer.h modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/SecondaryVertex/plugins/TemplatedSecondaryVertexProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTau/JetTagComputer/plugins/JetTagProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @SWuchterl for master.

It involves the following packages:

• RecoBTag/Combined (reconstruction)
• RecoBTag/ImpactParameter (reconstruction)
• RecoBTag/SecondaryVertex (reconstruction)
• RecoBTau/JetTagComputer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71522e/44825/summary.html
COMMIT: 2972d60
CMSSW: CMSSW_15_1_X_2025-03-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47513/44825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 55
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920225
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

Thanks @SWuchterl !
Can you maybe take care also of SoftLepton ?

cmssw/RecoBTag/SoftLepton/plugins/SoftLepton.cc

Line 521 in 8f4b703

descriptions.addDefault(desc);

[mmusich]

@cmsbuild, please test

[SWuchterl]

@mmusich I tried, but I am not sure if I fully understand the leptonCands InputTag.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47513/43978

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoBTag/Combined/plugins/BTagProbabilityToDiscriminator.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/ImpactParameter/plugins/IPProducer.h modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/SecondaryVertex/plugins/TemplatedSecondaryVertexProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/SoftLepton/plugins/SoftLepton.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTau/JetTagComputer/plugins/JetTagProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47513/43978/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47513/43978/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47513/43979

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoBTag/Combined/plugins/BTagProbabilityToDiscriminator.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/ImpactParameter/plugins/IPProducer.h modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/SecondaryVertex/plugins/TemplatedSecondaryVertexProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTag/SoftLepton/plugins/SoftLepton.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File RecoBTau/JetTagComputer/plugins/JetTagProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

Pull request #47513 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71522e/44833/summary.html
COMMIT: 54cc22d
CMSSW: CMSSW_15_1_X_2025-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47513/44833/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 28
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920252
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1