Skip to content

[NGT] add validation (w.r.t. SIM) step for Phase-2 HLT timing and NGT workflows #47522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 6, 2025

PR description:

Title says it all, add validation (w.r..t SIM) and harvesting steps for Phase-2 HLT timing and NGT workflows.
This would allow to have quickly access to workflows in which we can test changes in the reconstruction (at HLT) and see effects at the validation level, without the need to run (the time expensive) offfline reconstruction step3.
The HLT validation procedure is incomplete (see issue #39362) but these workflows will also be useful when testing new additions to that.

PR validation:

runTheMatrix.py -l 29634.75,29634.751, 29634.752, 29634.753, 29634.754, 29634.755, 29634.77

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Mar 6, 2025

test parameters:

  • relval_opts = -w upgrade
  • workflows = 29634.75, 29634.751, 29634.752, 29634.753, 29634.754, 29634.755, 29634.77

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 6, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Mar 6, 2025

type ngt

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2025

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61f4db/44834/summary.html
COMMIT: 5c0ff86
CMSSW: CMSSW_15_1_X_2025-03-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47522/44834/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61f4db/44834/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61f4db/44834/git-merge-result

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920266
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich mmusich changed the title [NGT] add validation (w.r..t SIM) step for Phase-2 HLT timing and NGT workflows [NGT] add validation (w.r.tSIM) step for Phase-2 HLT timing and NGT workflows Mar 6, 2025
@mmusich mmusich changed the title [NGT] add validation (w.r.tSIM) step for Phase-2 HLT timing and NGT workflows [NGT] add validation (w.r.t. SIM) step for Phase-2 HLT timing and NGT workflows Mar 6, 2025
@Moanwar
Copy link
Contributor

Moanwar commented Mar 7, 2025

+Upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Mar 10, 2025

@cms-sw/pdmv-l2 kind ping if you agree with the changes proposed here.

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Mar 11, 2025

+1

1 similar comment
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ba9ffdc into cms-sw:master Mar 12, 2025
12 checks passed
@mmusich mmusich deleted the mm_validation_step_hltph2_wf branch March 12, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants