Skip to content

2025 Scenario #47536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

2025 Scenario #47536

merged 1 commit into from
Mar 12, 2025

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 8, 2025

PR description:

Add 2025 scenario.
I understand that we don't need cosmicsEra_Run3_2025 because we still turn off GE2/1 demonstrator reconstruction,
https://github.com/cms-sw/cmssw/blob/master/RecoLocalMuon/GEMRecHit/python/gemRecHits_cfi.py
run3_GEM_2025.toModify(gemRecHits, ge21Off=True, applyMasking=True)

PR validation:

none

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need backport to 15_0 for data taking

commit 5bc33d8
Author: Norraphat <[email protected]>
Date:   Sun Mar 9 00:19:30 2025 +0100

    fix RecoTLR

commit bd959e6
Author: Norraphat <[email protected]>
Date:   Sun Mar 9 00:11:12 2025 +0100

    2025 scenario

commit ebac7cf
Author: Norraphat <[email protected]>
Date:   Sun Mar 9 00:08:38 2025 +0100

    2025 scenario
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47536/43997

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2025

A new Pull Request was created by @srimanob for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Mar 8, 2025

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2025

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f68df0/44862/summary.html
COMMIT: 28ef813
CMSSW: CMSSW_15_1_X_2025-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47536/44862/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920274
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

@smuzaffar @cms-sw/orp-l2 @mandrenguyen
Shahzad, a quick question on the bot: was this supposed to have been labeled as fully signed, with only operations and orp missing?
Thanks.

@smuzaffar
Copy link
Contributor

@antoniovilela , yes bot normally auto sign operations when tests are passed. This is only done when there are other non operations and orp categories. For this Pr as there is no other category so that is why bot did not sign operations and did not add the fully-signed label.

This was done on purpose to avoid adding a fully-signed label for PRs which no one has reviewed

@antoniovilela
Copy link
Contributor

@antoniovilela , yes bot normally auto sign operations when tests are passed. This is only done when there are other non operations and orp categories. For this Pr as there is no other category so that is why bot did not sign operations and did not add the fully-signed label.

This was done on purpose to avoid adding a fully-signed label for PRs which no one has reviewed

Ok, understood

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 0d07c32 into cms-sw:master Mar 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants