[UBSAN] added deps on TrackerRecHit2D for BaseTrackerRecHit

[smuzaffar]

Fixes UBSAN link error [a] which was introduced after #47441 intergation

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_15_1_UBSAN_X_2025-03-07-2300/SimDataFormats/TrackingAnalysis

 ld.bfd: tmp/el8_amd64_gcc12/src/SimDataFormats/TrackingAnalysis/src/SimDataFormatsTrackingAnalysis/SimDoublets.cc.o:(.data.rel+0x758): undefined reference to `typeinfo for BaseTrackerRecHit'

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test for CMSSW_15_1_UBSAN_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47537/43999

• There are other open Pull requests which might conflict with changes you have proposed:
  • File SimDataFormats/TrackingAnalysis/BuildFile.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• SimDataFormats/TrackingAnalysis (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @HuguesBrun, @VinInn, @VourMa, @abbiendi, @andrea21z, @apsallid, @bsunanda, @cericeci, @denizsun, @fabiocos, @jhgoh, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @salimcerci, @trocino, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eecea0/44867/summary.html
COMMIT: 89ded6b
CMSSW: CMSSW_15_1_UBSAN_X_2025-03-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47537/44867/install.sh to create a dev area with all the needed externals and cmssw changes.

[smuzaffar]

Please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eecea0/44874/summary.html
COMMIT: 89ded6b
CMSSW: CMSSW_15_1_X_2025-03-09-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47537/44874/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920259
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/simulation-l2 , can you please review this? This fixes the UBSAN build/link errors

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@cms-sw/orp-l2 , can you please sign/review this? This should fix the build errors in UBSAN IBs

[antoniovilela]

+1