Skip to content

[15_0] Include CICADA v2.2.0 configuration as modification to 2025 L1T Era #47559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

aloeliger
Copy link
Contributor

@aloeliger aloeliger commented Mar 11, 2025

backport of #47423

PR description:

This PR updates the CICADA L1T Emulator to the proposed model version v2.2.0 for 2025 running. This PR is dependent on cms-sw/cmsdist#9709

EDIT: I made a mistake and forgot that the CICADA external did not make it into 15_0, but 15_1. This PR is now dependent on PR: cms-sw/cmsdist#9743

PR validation:

The python pathing has been tested to work. The CICADA model has been tested locally to run and provide model accurate CICADA scores.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport to 15_0 for including the proper emulator in the data-taking release, and for proper DQM.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2025

A new Pull Request was created by @aloeliger for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • L1Trigger/L1TCaloLayer1 (l1)

@aloeliger, @antoniovilela, @cmsbuild, @davidlange6, @epalencia, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2025

cms-bot internal usage

@aloeliger
Copy link
Contributor Author

please test with cms-sw/cmsdist#9743

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/44922/summary.html
COMMIT: a159456
CMSSW: CMSSW_15_0_X_2025-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47559/44922/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/44922/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/44922/git-merge-result

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor Author

The trigger results change to CICADA is expected.

@aloeliger
Copy link
Contributor Author

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9743

@missirol
Copy link
Contributor

@aloeliger , this PR needs to be rebased.

@cmsbuild
Copy link
Contributor

Pull request #47559 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again.

@aloeliger
Copy link
Contributor Author

@missirol It has been rebased, but as of yesterday I am no longer L1T's offline software convener and can't restart the tests.

@smuzaffar
Copy link
Contributor

please test

I wonder if I still have the ability to start the tests...

@aloeliger , no , not after cms-sw/cms-bot#2455 :-)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/45065/summary.html
COMMIT: 8a78a4b
CMSSW: CMSSW_15_0_X_2025-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47559/45065/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 19-Mar-2025 15:26:53 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCaloSummary_CICADA_vXp1p2 label='simCaloStage2Layer1Summary'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Mar-2025 15:26:39 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=L1TCaloSummary_CICADA_vXp1p2 label='simCaloStage2Layer1Summary'
Exception Message:
A std::exception was thrown.
hls4ml emulator model library dlopen failure!
----- End Fatal Exception -------------------------------------------------

@aloeliger
Copy link
Contributor Author

Ahh, it wasn't tested with cms-sw/cmsdist#9743. Sorry, that is required.

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/45071/summary.html
COMMIT: 8a78a4b
CMSSW: CMSSW_15_0_X_2025-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47559/45071/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/45071/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-497560/45071/git-merge-result

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4019958
  • DQMHistoTests: Total failures: 86
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4019852
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 4 / 48 workflows

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9743

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9cae7d2 into cms-sw:CMSSW_15_0_X Mar 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants