Remove configuration support for SubProcess and its tests

[wddgit]

PR description:

Remove support for configuring SubProcess in a cmsRun job. This leaves the SubProcess feature completely disabled so it can no longer be run. Subsequent PRs will remove other code related to SubProcess from the Framework. Everything except the support for module sharing in EventSetup will eventually be removed. Most, maybe all, of the remaining code to be deleted is C++ code.

This PR also removes all the code related to unit tests of the SubProcess feature, including test modules and test data types only used for the SubProcess tests. Some tests are entirely removed. Some tests include parts that test SubProcess and some parts that test other things and those are only partially removed.

Matti announced that this change was coming here: https://cms-talk.web.cern.ch/t/removal-of-subprocess-feature/117449 and also in the O&C meeting a few weeks ago. We received no feedback or complaints.

Resolves cms-sw/framework-team#1278

PR validation:

Relies on existing tests. This does not include any new functionality. Mostly it is deletions.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47565/44050

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/src/SubProcess.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467, Compartmentalize how ProductRegistry is filled #47533
  • File FWCore/Framework/test/stubs/ToyAnalyzers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File FWCore/Integration/plugins/ESTestAnalyzers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File FWCore/Integration/plugins/ESTestProducers.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Implement a GenericCloner test module #47504, Remove FinalPath from the framework #47546
  • File FWCore/ParameterSet/python/Config.py modified in PR(s): faster edmConfigDump with --prune, also prunes unreferenced PSets #43276, Introduce vFloat and float types in ParameterSets #45216, Remove FinalPath from the framework #47546
  • File FWCore/ServiceRegistry/interface/ActivityRegistry.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467

[wddgit]

please test

[cmsbuild]

A new Pull Request was created by @wddgit for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)
• FWCore/ParameterSet (core)
• FWCore/ServiceRegistry (core)
• IOPool/Input (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 128KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad6db/44928/summary.html
COMMIT: b623924
CMSSW: CMSSW_15_1_X_2025-03-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47565/44928/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreConcurrency had ERRORS

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3920300
• DQMHistoTests: Total failures: 76
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3920204
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[wddgit]

please test

I don't think the changes in this PR could cause a unit test in FWCore/Concurrency to fail. FWCore/Concurrency does not depend on any package modified by this PR. Lets try again... The log file does not give much insight into the problem and the FWCore/Concurrency tests pass in my local working area.

[iarspider]

TestTime:3601 - the test timed out. Happens in IBs as well, #45487

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad6db/44941/summary.html
COMMIT: b623924
CMSSW: CMSSW_15_1_X_2025-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47565/44941/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreConcurrency had ERRORS

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3927028
• DQMHistoTests: Total failures: 25
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3926983
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #47071

[makortel]

ignore tests-rejected with ib-failure

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1