Skip to content

Conversation

@nurfikri89
Copy link
Contributor

Backport of #47490

Original PR description:

This PR makes the following changes

  1. Add a check of decayModeFinding tauID when selecting taus in getMETUncertainties() function. The decayModeFinding tauID is not in slimmedTaus in the latest MiniAOD and that collection is used
    to recalculate MET uncertainties.
  2. Add Pileup Jet Id and UParTv1 in helper functions used for reclustering AK4, AK8 Puppi jets and PuppiMET.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported for MiniAODv6 & NanoAODv15

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

A new Pull Request was created by @nurfikri89 for CMSSW_15_0_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • PhysicsTools/PatUtils (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2025

cms-bot internal usage

@jfernan2
Copy link
Contributor

enable nano

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b28345/44960/summary.html
COMMIT: afd579e
CMSSW: CMSSW_15_0_X_2025-03-13-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47585/44960/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 228 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4018889
  • DQMHistoTests: Total failures: 4092
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4014777
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 89951
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 89951
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 22 files compared)
  • Checked 113 log files, 65 edm output root files, 23 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.110 3.110 0.000 ( +0.0% ) 5.07 6.83 -25.7% 2.569 2.584
2500.002 3.227 3.227 0.000 ( +0.0% ) 4.52 6.09 -25.9% 3.013 3.005
2500.003 3.167 3.167 0.000 ( +0.0% ) 4.71 6.30 -25.2% 2.987 2.984
2500.011 1.642 1.642 0.000 ( +0.0% ) 8.26 11.57 -28.6% 2.652 2.654
2500.012 2.180 2.180 0.000 ( +0.0% ) 4.88 6.38 -23.4% 2.843 2.838
2500.013 1.997 1.997 0.000 ( +0.0% ) 6.76 9.09 -25.6% 2.754 2.748
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.34 2.00 -33.3% 2.688 2.681
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.35 1.89 -28.7% 2.681 2.673
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.22 1.86 -34.4% 2.546 2.548
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.07 1.49 -27.9% 2.774 2.777
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.14 1.73 -34.3% 2.742 2.741
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.08 1.73 -37.5% 2.695 2.696
2500.033 0.037 0.037 -0.000 ( -0.1% ) 1.13 1.63 -30.5% 2.780 2.773
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.08 1.66 -34.6% 2.762 2.761
2500.101 2.850 2.850 0.000 ( +0.0% ) 10.92 16.34 -33.2% 2.649 2.641
2500.111 1.469 1.469 0.000 ( +0.0% ) 20.80 31.69 -34.4% 2.335 2.334
2500.112 1.889 1.889 0.000 ( +0.0% ) 15.71 26.05 -39.7% 2.411 2.410
2500.131 0.750 0.750 0.000 ( +0.0% ) 26.09 37.56 -30.5% 1.507 1.499
2500.201 2.679 2.679 0.000 ( +0.0% ) 8.93 13.48 -33.8% 2.211 2.208
2500.211 1.836 1.836 0.000 ( +0.0% ) 18.10 27.43 -34.0% 2.404 2.403
2500.212 2.233 2.233 0.000 ( +0.0% ) 14.96 22.52 -33.6% 2.486 2.482
2500.221 2.115 2.115 0.000 ( +0.0% ) 9.53 14.10 -32.4% 2.130 2.124
2500.222 3.487 3.487 0.000 ( +0.0% ) 8.37 13.37 -37.4% 2.224 2.213
2500.223 9.490 9.490 0.000 ( +0.0% ) 3.25 4.91 -33.7% 2.339 2.340
2500.224 6.604 6.604 0.000 ( +0.0% ) 0.94 1.24 -23.8% 2.344 2.338
2500.225 6.652 6.652 0.000 ( +0.0% ) 0.86 1.17 -26.4% 2.549 2.551
2500.226 3.180 3.180 0.000 ( +0.0% ) 8.74 13.95 -37.3% 2.220 2.217
2500.227 1.442 1.442 0.000 ( +0.0% ) 17.03 23.58 -27.8% 1.443 1.443
2500.228 3.996 3.996 0.000 ( +0.0% ) 6.68 8.83 -24.4% 2.318 2.316
2500.231 1.512 1.512 0.000 ( +0.0% ) 15.11 22.76 -33.6% 2.315 2.314
2500.232 2.493 2.493 0.000 ( +0.0% ) 15.00 21.15 -29.1% 2.408 2.397
2500.233 4.986 4.986 0.000 ( +0.0% ) 5.13 7.05 -27.2% 2.526 2.521
2500.234 3.919 3.919 0.000 ( +0.0% ) 1.22 1.55 -21.4% 2.484 2.485
2500.235 3.950 3.950 0.000 ( +0.0% ) 1.16 1.48 -21.6% 2.681 2.686
2500.236 2.282 2.282 0.000 ( +0.0% ) 15.31 21.25 -28.0% 2.393 2.400
2500.237 1.018 1.018 0.000 ( +0.0% ) 26.90 33.91 -20.7% 1.460 1.452
2500.238 2.469 2.469 0.000 ( +0.0% ) 13.40 16.89 -20.7% 2.489 2.481
2500.241 9.404 9.404 0.000 ( +0.0% ) 4.60 7.36 -37.6% 1.925 1.925
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.28 1.63 -21.3% 1.725 1.727
2500.243 2.712 2.712 0.000 ( +0.0% ) 11.33 15.81 -28.3% 1.064 1.059
2500.244 486.016 486.016 0.000 ( +0.0% ) 0.88 1.14 -22.9% 1.721 1.684
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.13 1.53 -26.1% 1.682 1.664
2500.251 645.314 645.314 0.000 ( +0.0% ) 1.30 1.65 -21.6% 1.782 1.779
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.25 1.77 -29.4% 2.796 2.792
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.32 1.73 -23.6% 2.739 2.740
2500.901 1.819 1.819 0.000 ( +0.0% ) 27.65 43.00 -35.7% 1.447 1.444
2500.902 1.665 1.665 0.000 ( +0.0% ) 31.69 47.05 -32.7% 1.338 1.338
2500.911 14.345 14.345 0.000 ( +0.0% ) 7.65 8.39 -8.8% 1.088 1.089
2500.912 0.240 0.199 0.041 ( +20.8% ) 2.72 2.61 +4.1% 0.844 0.849
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.92 2.63 -26.7% 0.851 0.854

@hqucms
Copy link
Contributor

hqucms commented Mar 13, 2025

+1

@jfernan2
Copy link
Contributor

It is strange how in this backport the nano tests show and increase while the test at master went in the opposite direction: #47490 (comment)

@hqucms
Copy link
Contributor

hqucms commented Mar 13, 2025

It is strange how in this backport the nano tests show and increase while the test at master went in the opposite direction: #47490 (comment)

It seems that the NANO timing performance reported in these tests are not very stable (as discussed in #47206).

@jfernan2
Copy link
Contributor

+1
We don't have a reliable way to measure the impact of any change on NANO

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

urgent
needed for data taking

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 11b84ba into cms-sw:CMSSW_15_0_X Mar 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants