provide a `fillDescriptions` method for `CondDBESSource` #47630

mmusich · 2025-03-19T20:27:32Z

PR description:

Title says it all, as suggested at #47171 (comment).

PR validation:

The branch passes:

addOnTests.py
runTheMatrix.py -l Run3 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_15_0_X for 2025 operations.

cmsbuild · 2025-03-19T20:27:59Z

cms-bot internal usage

cmsbuild · 2025-03-19T20:29:58Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47630/44155

There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/ESSources/plugins/CondDBESSource.cc modified in PR(s): Print diagnostics on ProductResolver's loadTag setIntervalFor and IOVProxy's fetchSequence #47171
- File CondCore/ESSources/plugins/CondDBESSource.h modified in PR(s): Print diagnostics on ProductResolver's loadTag setIntervalFor and IOVProxy's fetchSequence #47171
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): CA Extension to strips #47090, A More Flexible And Lightweight CA #47611, Level-1 Scouting DQM #47627

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47630/44155/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47630/44155/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2025-03-19T20:35:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47630/44156

There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/ESSources/plugins/CondDBESSource.cc modified in PR(s): Print diagnostics on ProductResolver's loadTag setIntervalFor and IOVProxy's fetchSequence #47171
- File CondCore/ESSources/plugins/CondDBESSource.h modified in PR(s): Print diagnostics on ProductResolver's loadTag setIntervalFor and IOVProxy's fetchSequence #47171
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): CA Extension to strips #47090, A More Flexible And Lightweight CA #47611, Level-1 Scouting DQM #47627

cmsbuild · 2025-03-19T20:36:01Z

Pull request #47630 was updated.

mmusich · 2025-03-19T20:36:19Z

@cmsbuild, please test

cmsbuild · 2025-03-19T20:57:51Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-633afd/45084/summary.html
COMMIT: 89d477f
CMSSW: CMSSW_15_1_X_2025-03-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47630/45084/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS

RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
1000.01000.0_RunMinBias2011A/step2_RunMinBias2011A.log
1306.01306.0_SingleMuPt1_UP15/step1_SingleMuPt1_UP15.log

Expand to see more relval errors ...

RelVals-INPUT

145.711145.711_RunParkingSingleMuon02024I/step2_RunParkingSingleMuon02024I.log
145.31145.31_RunParkingLLP2024E/step2_RunParkingLLP2024E.log
159.01159.01_HydjetQ_reminiaodPbPb2022_INPUT/step2_HydjetQ_reminiaodPbPb2022_INPUT.log

Expand to see more relval errors ...

AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

mmusich · 2025-03-22T13:06:03Z

the last push introduces a new unit test that can be run via scram b runtests_UnitTestLoadConditions that tests loading conditions with different setups of the PoolDBESSource re-cycling some of the files in CondCore/ESSources/test/python/

mmusich · 2025-03-22T13:06:10Z

@cmsbuild, please test

cmsbuild · 2025-03-22T15:00:21Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-633afd/45150/summary.html
COMMIT: cbe91c6
CMSSW: CMSSW_15_1_X_2025-03-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47630/45150/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3909207
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3909183
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich · 2025-03-22T15:02:41Z

The new unit tests was successful (see log).

mmusich · 2025-03-22T15:02:45Z

unhold

perrotta · 2025-03-22T15:20:09Z

+1

cmsbuild · 2025-03-22T15:20:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-03-23T11:27:43Z

+1

perrotta · 2025-03-24T07:11:45Z

@mmusich should this also get backported, in view of the merge in 150X of #47619?

perrotta · 2025-03-24T07:17:17Z

@mmusich should this also get backported, in view of the merge in 150X of #47619?

Uhm, indeed there are a few unit tests to be fixed first, see Unit test errors in the IBs

mmusich · 2025-03-24T09:36:25Z

should this also get backported, in view of the merge in 150X of #47619?

yes, it's in my plans.

Uhm, indeed there are a few unit tests to be fixed first, see Unit test errors in the IBs

see #47675

cmsbuild added this to the CMSSW_15_1_X milestone Mar 19, 2025

cmsbuild added hlt-pending alca-pending db-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 19, 2025

mmusich force-pushed the mm_provide_fillDesc_CondDBESSource branch from fec2563 to f41c9b7 Compare March 19, 2025 20:29

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 19, 2025

mmusich force-pushed the mm_provide_fillDesc_CondDBESSource branch from f41c9b7 to 89d477f Compare March 19, 2025 20:33

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 19, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 19, 2025

cmsbuild added tests-started and removed tests-pending labels Mar 19, 2025

cmsbuild added tests-rejected and removed tests-started labels Mar 19, 2025

mmusich force-pushed the mm_provide_fillDesc_CondDBESSource branch from 89d477f to 8b3f096 Compare March 19, 2025 21:04

cmsbuild added tests-pending and removed tests-rejected code-checks-approved labels Mar 19, 2025

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2025

cmsbuild added tests-approved and removed tests-started labels Mar 22, 2025

cmsbuild removed the hold label Mar 22, 2025

cmsbuild added alca-approved fully-signed db-approved and removed alca-pending db-pending pending-signatures labels Mar 22, 2025

cmsbuild added orp-approved and removed orp-pending labels Mar 23, 2025

cmsbuild merged commit bf4a710 into cms-sw:master Mar 23, 2025
11 checks passed

mmusich deleted the mm_provide_fillDesc_CondDBESSource branch March 23, 2025 12:11

mmusich mentioned this pull request Mar 24, 2025

fix a bunch of test configuration files for invalid PoolDBESSoure parameters #47675

Merged

This was referenced Mar 24, 2025

[15.0.X] provide a fillDescriptions method for CondDBESSource #47676

Merged

remove empty cms.PSet() from auto-generated default_CondDBESource_cfi file #47688

Merged

mmusich mentioned this pull request Apr 12, 2025

Removal of illegal PoolDBESSource parameters #47851

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provide a `fillDescriptions` method for `CondDBESSource` #47630

provide a `fillDescriptions` method for `CondDBESSource` #47630

mmusich commented Mar 19, 2025

cmsbuild commented Mar 19, 2025 •

edited

Loading

cmsbuild commented Mar 19, 2025

cmsbuild commented Mar 19, 2025

cmsbuild commented Mar 19, 2025

mmusich commented Mar 19, 2025

cmsbuild commented Mar 19, 2025

mmusich commented Mar 22, 2025

mmusich commented Mar 22, 2025

cmsbuild commented Mar 22, 2025

mmusich commented Mar 22, 2025

mmusich commented Mar 22, 2025

perrotta commented Mar 22, 2025

cmsbuild commented Mar 22, 2025

mandrenguyen commented Mar 23, 2025

perrotta commented Mar 24, 2025

perrotta commented Mar 24, 2025

mmusich commented Mar 24, 2025

provide a fillDescriptions method for CondDBESSource #47630

provide a fillDescriptions method for CondDBESSource #47630

Conversation

mmusich commented Mar 19, 2025

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 19, 2025 • edited Loading

cmsbuild commented Mar 19, 2025

cmsbuild commented Mar 19, 2025

cmsbuild commented Mar 19, 2025

mmusich commented Mar 19, 2025

cmsbuild commented Mar 19, 2025

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

mmusich commented Mar 22, 2025

mmusich commented Mar 22, 2025

cmsbuild commented Mar 22, 2025

Comparison Summary

mmusich commented Mar 22, 2025

mmusich commented Mar 22, 2025

perrotta commented Mar 22, 2025

cmsbuild commented Mar 22, 2025

mandrenguyen commented Mar 23, 2025

perrotta commented Mar 24, 2025

perrotta commented Mar 24, 2025

mmusich commented Mar 24, 2025

provide a `fillDescriptions` method for `CondDBESSource` #47630

provide a `fillDescriptions` method for `CondDBESSource` #47630

cmsbuild commented Mar 19, 2025 •

edited

Loading