-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix supercluster input in the dumper #47681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47681/44223 |
|
A new Pull Request was created by @AuroraPerego for master. It involves the following packages:
@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters: |
|
@cmsbuild, please test |
|
type bug-fix |
|
+1 Size: This PR adds an extra 20KB to repository
Comparison SummarySummary:
|
|
+1 |
|
+Upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47681/44255 |
|
Hi @AuroraPerego , Isn't the first commit fixes the issue of supercluster ? |
|
@cmsbuild, please test |
yes, but then I had to solve the conflict arising from the merge of #47576 |
|
+1 Size: This PR adds an extra 20KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here:
Comparison SummarySummary:
|
|
+Upgrade |
|
+1 |
PR description:
The trackster collection used as input to the supercluster collection in the
TICLDumperwas wrong, leading to crashed when running it.This PR fixes it by passing the correct collection in the
TICLDumper.PR validation:
tested on wfs 29688.0 and 29688.203 enabling the
TICLDumper@waredjeb @felicepantaleo