Skip to content

Conversation

@AuroraPerego
Copy link
Contributor

PR description:

The trackster collection used as input to the supercluster collection in the TICLDumper was wrong, leading to crashed when running it.
This PR fixes it by passing the correct collection in the TICLDumper.

PR validation:

tested on wfs 29688.0 and 29688.203 enabling the TICLDumper

@waredjeb @felicepantaleo

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AuroraPerego for master.

It involves the following packages:

  • RecoHGCal/TICL (reconstruction, upgrade)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @salimcerci, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Moanwar
Copy link
Contributor

Moanwar commented Mar 25, 2025

test parameters:
workflow_opts = -w upgrade
workflows = 29688.0,29688.203

@Moanwar
Copy link
Contributor

Moanwar commented Mar 25, 2025

@cmsbuild, please test

@Moanwar
Copy link
Contributor

Moanwar commented Mar 25, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287746/45182/summary.html
COMMIT: e770dfe
CMSSW: CMSSW_15_1_X_2025-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47681/45182/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4131945
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4131916
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 225 log files, 192 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Mar 26, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47681 was updated. @cmsbuild can you please check and sign again.

@Moanwar
Copy link
Contributor

Moanwar commented Mar 26, 2025

Hi @AuroraPerego , Isn't the first commit fixes the issue of supercluster ?

@Moanwar
Copy link
Contributor

Moanwar commented Mar 26, 2025

@cmsbuild, please test

@AuroraPerego
Copy link
Contributor Author

Hi @AuroraPerego , Isn't the first commit fixes the issue of supercluster ?

yes, but then I had to solve the conflict arising from the merge of #47576

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287746/45217/summary.html
COMMIT: 2d75472
CMSSW: CMSSW_15_1_X_2025-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47681/45217/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287746/45217/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287746/45217/git-merge-result

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4131945
  • DQMHistoTests: Total failures: 62
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4131863
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 225 log files, 192 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@Moanwar
Copy link
Contributor

Moanwar commented Mar 26, 2025

+Upgrade

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8d918ae into cms-sw:master Mar 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants