-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Phase2-gex187Y Create the scenario for V19 (still under test) #47695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47695/44245
|
@cmsbuild Please test |
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 72KB to repository Comparison SummarySummary:
|
+geometry |
@subirsarkar Please approve this |
@Moanwar, @subirsarkar, Please approve this |
+Upgrade |
@AdrianoDee, Please approve this PR |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
'Geom' : 'ExtendedRun4D120', | ||
'HLTmenu': '@relvalRun4', | ||
'GT' : 'auto:phase2_realistic_T33', | ||
'Era' : 'Phase2C22I13M9', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR (already signed) but why we have naming for Phase2 eras that does not sound like they correspond to the actual detector setup. E.g. here Phase2C22I13M9
suggest C22+I13+M9
but D120
is different. Is it that there's no needed modification (in terms of era) from C22+I13+M9
to C26+I20+M15
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not strictly necessary here. The transition to C22 happened because of handling two collections in a calorimeter class.. Otherwise C17 would have been sufficient. I think for all new scenarios should use C22 rather than C17. The jumps from Mx to My follows similar principles.
+1 |
PR description:
Create the scenario for V19 (still under test)
PR validation:
Only the SIM step is complete. We are working on improving different options. There are several issues still to be completed. It is an interim state and required for debugging this version.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special