Skip to content

Phase2-gex187Y Create the scenario for V19 (still under test) #47695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 26, 2025

PR description:

Create the scenario for V19 (still under test)

PR validation:

Only the SIM step is complete. We are working on improving different options. There are several issues still to be completed. It is an interim state and required for debugging this version.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47695/44245

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (upgrade, geometry)

@AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @vargasa this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d82a87/45204/summary.html
COMMIT: 590d5cd
CMSSW: CMSSW_15_1_X_2025-03-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47695/45204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

+geometry

@bsunanda
Copy link
Contributor Author

@subirsarkar Please approve this

@bsunanda
Copy link
Contributor Author

@Moanwar, @subirsarkar, Please approve this

@Moanwar
Copy link
Contributor

Moanwar commented Mar 26, 2025

+Upgrade

@bsunanda
Copy link
Contributor Author

@AdrianoDee, Please approve this PR

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

'Geom' : 'ExtendedRun4D120',
'HLTmenu': '@relvalRun4',
'GT' : 'auto:phase2_realistic_T33',
'Era' : 'Phase2C22I13M9',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR (already signed) but why we have naming for Phase2 eras that does not sound like they correspond to the actual detector setup. E.g. here Phase2C22I13M9 suggest C22+I13+M9 but D120 is different. Is it that there's no needed modification (in terms of era) from C22+I13+M9 to C26+I20+M15?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not strictly necessary here. The transition to C22 happened because of handling two collections in a calorimeter class.. Otherwise C17 would have been sufficient. I think for all new scenarios should use C22 rather than C17. The jumps from Mx to My follows similar principles.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 84f274e into cms-sw:master Mar 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants