Skip to content

Update 2025 HMT shower thresholds for pp collision #47701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Mar 26, 2025

PR description:

This PR updates 2025 HMT shower thresholds for pp collision.
This set of thresholds will be used for 2025 initial pp collision data-taking, and will be necessary for any emulator comparison.
Details are presented in the L1 DPG meeting on March 24[1].
@santeri

[1]https://indico.cern.ch/event/1529818/contributions/6436557/attachments/3037597/5367253/MDS_L1_thresholds_2025.pdf

PR validation:

Tested with local HMT nTuple cfg:
https://github.com/kakwok/HMTntuple/blob/main/CSCShowerAnalyzer/test/runCSCShowerAnalyzer_cfg.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be backported to CMSSW_15_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47701/44257

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kakwok for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • L1Trigger/CSCTriggerPrimitives (l1)

@BenjaminRS, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @quinnanm, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @eyigitba, @fabiocos, @giovanni-mocellin, @makortel, @missirol, @mmusich, @ptcox, @valuev this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@quinnanm
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3efe73/45221/summary.html
COMMIT: 3cb297e
CMSSW: CMSSW_15_1_X_2025-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47701/45221/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3909207
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3909141
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@BenjaminRS
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@BenjaminRS
Copy link
Contributor

@kakwok please make the back port to CMSSW_15_0_X

@mandrenguyen
Copy link
Contributor

@kakwok please make the back port to CMSSW_15_0_X

@cms-sw/l1-l2
Please bring up the backport to the production release at the next ORP meeting on Tues April 1st.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5046b36 into cms-sw:master Mar 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants