Move RandomNumberGenerator service base class to FWCore/AbstractServices

[makortel]

PR description:

This PR moves RandomNumberGenerator service base class to FWCore/AbstractServices. It is the last abstract service base class that was in FWCore/Utilities.

The second commit is about applying code checks and format to Pythi8Hadronizer.cc in order to make the bot happy.

Resolves cms-sw/framework-team#1266

PR validation:

Code compiles

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44281

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467, Remove SubProcess and references in EventProcessor related code #47659, Fix bug in endUnfinishedLumi #47707
  • File FWCore/Framework/src/Schedule.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858, Access PathsAndConsumesOfModules from new signal #47467, Remove SubProcess and references in EventProcessor related code #47659
  • File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Implement a GenericCloner test module #47504
  • File FWCore/Integration/plugins/RandomIntProducer.cc modified in PR(s): Removed -Wconversion warnings in part of framework #47339
  • File GeneratorInterface/LHEInterface/plugins/ExternalLHEProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): Fix cross section when using ResonanceDecayFilter #46725
  • File IOMC/RandomEngine/plugins/RandomNumberGeneratorService.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
  • File SimMuon/RPCDigitizer/src/RPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447
  • File SimMuon/RPCDigitizer/src/RPCandIRPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44281/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44281/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44281/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44281/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44282

• There are other open Pull requests which might conflict with changes you have proposed:
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467, Remove SubProcess and references in EventProcessor related code #47659, Fix bug in endUnfinishedLumi #47707
  • File FWCore/Framework/src/Schedule.cc modified in PR(s): Disable ROOT automatic class parsing during finishSchedule() #46858, Access PathsAndConsumesOfModules from new signal #47467, Remove SubProcess and references in EventProcessor related code #47659
  • File FWCore/Integration/plugins/BuildFile.xml modified in PR(s): Implement a GenericProduct and GenericCloner test module #46821, Implement a GenericCloner test module #47504
  • File FWCore/Integration/plugins/RandomIntProducer.cc modified in PR(s): Removed -Wconversion warnings in part of framework #47339
  • File GeneratorInterface/LHEInterface/plugins/ExternalLHEProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): Fix cross section when using ResonanceDecayFilter #46725
  • File IOMC/RandomEngine/plugins/RandomNumberGeneratorService.h modified in PR(s): Access PathsAndConsumesOfModules from new signal #47467
  • File SimMuon/RPCDigitizer/src/RPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447
  • File SimMuon/RPCDigitizer/src/RPCandIRPCDigiProducer.cc modified in PR(s): Rpc digi dev v9 #47447

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44282/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47719/44282/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[tvami]

+1

[jfernan2]

+1

[civanch]

+1

[BenjaminRS]

+l1

[antoniovagnerini]

+dqm

[makortel]

@cms-sw/generators-l2 Could you review and sign? Thanks!

[lviliani]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1