CALO-L2 EG, Tau, Jet calibrations with conservative ZS for first L1 menu 2025 #47730

Pmeiring · 2025-03-28T22:22:04Z

PR description:

This PR introduces the calibrations of the CALO-L2 objects for the first L1 menu of 2025.

The caloParams file includes the conservative ZS scheme from:
https://indico.cern.ch/event/1524376/#31-technical-instructions-for

This PR depends on:
cms-data/L1Trigger-L1TCalorimeter#27

PR validation:

To be validated

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild · 2025-03-28T22:22:31Z

cms-bot internal usage

cmsbuild · 2025-03-28T22:23:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47730/44304

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/customiseSettings.py modified in PR(s): Clean caloParams #43154, Zero Suppression for L1TCaloLayer1 #47712

cmsbuild · 2025-03-28T22:24:20Z

A new Pull Request was created by @Pmeiring for master.

It involves the following packages:

L1Trigger/Configuration (l1)
L1Trigger/L1TCalorimeter (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-03-29T14:45:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47730/44306

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/customiseSettings.py modified in PR(s): Clean caloParams #43154, Zero Suppression for L1TCaloLayer1 #47712

cmsbuild · 2025-03-29T14:45:29Z

Pull request #47730 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

cmsbuild · 2025-03-29T16:09:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47730/44307

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/customiseSettings.py modified in PR(s): Clean caloParams #43154, Zero Suppression for L1TCaloLayer1 #47712

cmsbuild · 2025-03-29T16:09:47Z

Pull request #47730 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

cmsbuild · 2025-03-29T23:21:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47730/44308

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/customiseSettings.py modified in PR(s): Clean caloParams #43154, Zero Suppression for L1TCaloLayer1 #47712

cmsbuild · 2025-03-29T23:21:48Z

Pull request #47730 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

quinnanm · 2025-03-30T17:03:26Z

please test

cmsbuild · 2025-04-15T15:14:39Z

Pull request #47730 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

BenjaminRS · 2025-04-15T15:37:12Z

test parameters:

pull_request = CALO-L2 EG, Tau, Jet calibrations for first L1 menu 2025 cms-data/L1Trigger-L1TCalorimeter#27

BenjaminRS · 2025-04-15T15:37:40Z

please test

cmsbuild · 2025-04-16T10:16:26Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e600f8/45563/summary.html
COMMIT: 966002e
CMSSW: CMSSW_15_1_X_2025-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47730/45563/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e600f8/45563/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e600f8/45563/git-merge-result

Comparison Summary

Summary:

You potentially added 150 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3904465
DQMHistoTests: Total failures: 2908
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3901537
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
DQMHistoSizes: changed ( 145.014 ): -14484.059 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 145.014 ): 13252.701 KiB HLT/Tracking
DQMHistoSizes: changed ( 145.014 ): 10484.856 KiB HLT/EGM
DQMHistoSizes: changed ( 145.014 ): 10390.469 KiB HLT/SiStrip
DQMHistoSizes: changed ( 145.014 ): 9022.441 KiB HLT/Pixel
DQMHistoSizes: changed ( 145.014 ): 4970.328 KiB HLT/BTV
DQMHistoSizes: changed ( 145.014 ): -3543.336 KiB Tracking/V0Monitoring
DQMHistoSizes: changed ( 145.014 ): 1760.164 KiB HLT/EXO
DQMHistoSizes: changed ( 145.014 ): -1162.402 KiB L1TEMU/L1TObjects
DQMHistoSizes: changed ( 145.014 ): -1160.753 KiB L1T/L1TObjects
DQMHistoSizes: changed ( 145.014 ): ...
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

BenjaminRS · 2025-04-16T10:50:14Z

+l1

cmsbuild · 2025-04-16T10:50:34Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-L1TCalorimeter#27

cmsbuild · 2025-04-16T10:56:21Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e600f8/45563/summary.html
COMMIT: 966002e
CMSSW: CMSSW_15_1_X_2025-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47730/45563/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e600f8/45563/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e600f8/45563/git-merge-result

Comparison Summary

Summary:

You potentially added 150 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3904465
DQMHistoTests: Total failures: 2954
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3901491
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
DQMHistoSizes: changed ( 145.014 ): -14484.059 KiB Tracking/TrackParameters
DQMHistoSizes: changed ( 145.014 ): 13252.701 KiB HLT/Tracking
DQMHistoSizes: changed ( 145.014 ): 10484.856 KiB HLT/EGM
DQMHistoSizes: changed ( 145.014 ): 10390.469 KiB HLT/SiStrip
DQMHistoSizes: changed ( 145.014 ): 9022.441 KiB HLT/Pixel
DQMHistoSizes: changed ( 145.014 ): 4970.328 KiB HLT/BTV
DQMHistoSizes: changed ( 145.014 ): -3543.336 KiB Tracking/V0Monitoring
DQMHistoSizes: changed ( 145.014 ): 1760.164 KiB HLT/EXO
DQMHistoSizes: changed ( 145.014 ): -1162.402 KiB L1TEMU/L1TObjects
DQMHistoSizes: changed ( 145.014 ): -1160.753 KiB L1T/L1TObjects
DQMHistoSizes: changed ( 145.014 ): ...
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

mandrenguyen · 2025-04-16T12:12:29Z

@Pmeiring @BenjaminRS This is now fully signed, but the corresponding calibrations are still in draft mode (cms-l1t-offline/L1Trigger-L1TCalorimeter#25)
Can you please clarify?

BenjaminRS · 2025-04-16T12:14:46Z

Hi @mandrenguyen -- we have now moved it away from the L1T offline sw fork and into cms-data here: cms-data/L1Trigger-L1TCalorimeter#27 which I have put as an external both for this PR and its backport: #47874

antoniovilela · 2025-04-16T20:04:48Z

cms-data/L1Trigger-L1TCalorimeter#27 is merged.
cmsdist PR: cms-sw/cmsdist#9797

antoniovilela · 2025-04-16T20:05:32Z

+1

cmsbuild added this to the CMSSW_15_1_X milestone Mar 28, 2025

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 28, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 28, 2025

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 29, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 29, 2025

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 29, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 29, 2025

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 29, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 29, 2025

cmsbuild added the requires-external label Apr 15, 2025

cmsbuild added tests-started and removed tests-pending labels Apr 15, 2025

This was referenced Apr 15, 2025

[15_0_X][L1T] CALO-L2 calibrations and cons. ZS for first L1 menu 2025 #47873

Closed

[15_0_X][L1T] CALO-L2 calibrations and cons. ZS for first L1 menu 2025 #47874

Merged

cmsbuild added tests-approved tests-started and removed tests-started tests-approved labels Apr 16, 2025

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Apr 16, 2025

cmsbuild mentioned this pull request Apr 16, 2025

CALO-L2 EG, Tau, Jet calibrations for first L1 menu 2025 cms-data/L1Trigger-L1TCalorimeter#27

Merged

cmsbuild added tests-approved and removed tests-started labels Apr 16, 2025

cmsbuild added orp-approved and removed orp-pending labels Apr 16, 2025

cmsbuild merged commit 4b2303d into cms-sw:master Apr 16, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CALO-L2 EG, Tau, Jet calibrations with conservative ZS for first L1 menu 2025 #47730

CALO-L2 EG, Tau, Jet calibrations with conservative ZS for first L1 menu 2025 #47730

Pmeiring commented Mar 28, 2025 •

edited

Loading

cmsbuild commented Mar 28, 2025 •

edited

Loading

cmsbuild commented Mar 28, 2025

cmsbuild commented Mar 28, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

quinnanm commented Mar 30, 2025

cmsbuild commented Apr 15, 2025

BenjaminRS commented Apr 15, 2025

BenjaminRS commented Apr 15, 2025

cmsbuild commented Apr 16, 2025

BenjaminRS commented Apr 16, 2025

cmsbuild commented Apr 16, 2025

cmsbuild commented Apr 16, 2025

mandrenguyen commented Apr 16, 2025

BenjaminRS commented Apr 16, 2025

antoniovilela commented Apr 16, 2025

antoniovilela commented Apr 16, 2025

CALO-L2 EG, Tau, Jet calibrations with conservative ZS for first L1 menu 2025 #47730

CALO-L2 EG, Tau, Jet calibrations with conservative ZS for first L1 menu 2025 #47730

Conversation

Pmeiring commented Mar 28, 2025 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 28, 2025 • edited Loading

cmsbuild commented Mar 28, 2025

cmsbuild commented Mar 28, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

quinnanm commented Mar 30, 2025

cmsbuild commented Apr 15, 2025

BenjaminRS commented Apr 15, 2025

BenjaminRS commented Apr 15, 2025

cmsbuild commented Apr 16, 2025

Comparison Summary

BenjaminRS commented Apr 16, 2025

cmsbuild commented Apr 16, 2025

cmsbuild commented Apr 16, 2025

Comparison Summary

mandrenguyen commented Apr 16, 2025

BenjaminRS commented Apr 16, 2025

antoniovilela commented Apr 16, 2025

antoniovilela commented Apr 16, 2025

Pmeiring commented Mar 28, 2025 •

edited

Loading

cmsbuild commented Mar 28, 2025 •

edited

Loading