Add a test for missing dictionaries with CUDA headers [15.0.x] #47732

fwyzard · 2025-03-29T07:08:12Z

PR description:

Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where:

T has a dictionary
edm::Wrapper<T> does not have a dictionary
the corresponding classes.h file includes CUDA headers

PR validation:

The new unit test currently fails, due to a known issue in the ROOT distribution (#47400).
Updating the ROOT build to generate the cuda.pcm file (cms-sw/cmsdist#9766) avoids the fatal exception, and lets ROOT report a missing dictionary normally.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #47731 and #47743.

Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where: - T has a dictionary - edm::Wrapper<T> does not have a dictionary - the corresponding classes.h file includes CUDA headers

fwyzard · 2025-03-29T07:08:27Z

backport #47731

cmsbuild · 2025-03-29T07:08:36Z

A new Pull Request was created by @fwyzard for CMSSW_15_0_X.

It involves the following packages:

HeterogeneousCore/CUDATest (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Backported from Add a test for missing dictionaries with CUDA headers #47731

cmsbuild · 2025-03-29T07:08:37Z

cms-bot internal usage

fwyzard · 2025-03-29T07:08:46Z

please test with cms-sw/cmsdist#9766

fwyzard · 2025-03-29T07:08:55Z

+heterogeneous

cmsbuild · 2025-03-29T07:09:03Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9766

cmsbuild · 2025-03-29T14:05:26Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47b605/45281/summary.html
COMMIT: facc142
CMSSW: CMSSW_15_0_X_2025-03-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47732/45281/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3999716
DQMHistoTests: Total failures: 65
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3999631
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-03-31T19:24:04Z

Pull request #47732 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

fwyzard · 2025-03-31T19:25:14Z

please test

cmsbuild · 2025-03-31T21:15:34Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47b605/45300/summary.html
COMMIT: 765b823
CMSSW: CMSSW_15_0_X_2025-03-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47732/45300/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testMissingDictionaryCUDA had ERRORS

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3999716
DQMHistoTests: Total failures: 57
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3999639
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

fwyzard · 2025-03-31T21:17:01Z

please test with cms-sw/cmsdist#9766

cmsbuild · 2025-04-01T04:07:51Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47b605/45303/summary.html
COMMIT: 765b823
CMSSW: CMSSW_15_0_X_2025-03-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47732/45303/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 13 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3999716
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3999693
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

fwyzard · 2025-04-01T15:11:42Z

+1

cmsbuild · 2025-04-01T15:12:04Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9766

mandrenguyen · 2025-04-02T05:28:59Z

hold
Will be merged once hold is lifted on cms-sw/cmsdist#9766

cmsbuild · 2025-04-02T05:29:21Z

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

Add a test for missing dictionaries with CUDA headers

facc142

Add a test to check that the framework handles correctly the case of edm::Wrapper<T> where: - T has a dictionary - edm::Wrapper<T> does not have a dictionary - the corresponding classes.h file includes CUDA headers

cmsbuild added this to the CMSSW_15_0_X milestone Mar 29, 2025

cmsbuild added pending-signatures tests-pending orp-pending backport heterogeneous-pending changes-dataformats labels Mar 29, 2025

cmsbuild added tests-started requires-external and removed tests-pending labels Mar 29, 2025

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Mar 29, 2025

cmsbuild mentioned this pull request Mar 29, 2025

Generate cuda.pcm if CUDA is available [15.0.x] cms-sw/cmsdist#9766

Open

cmsbuild added tests-approved backport-ok and removed tests-started backport labels Mar 29, 2025

Fix false positive

765b823

cmsbuild removed fully-signed tests-approved labels Mar 31, 2025

cmsbuild added pending-signatures tests-pending heterogeneous-pending and removed requires-external heterogeneous-approved labels Mar 31, 2025

cmsbuild added tests-started and removed tests-pending labels Mar 31, 2025

cmsbuild added tests-rejected and removed tests-started labels Mar 31, 2025

cmsbuild added requires-external tests-started and removed tests-rejected labels Mar 31, 2025

cmsbuild added tests-approved and removed tests-started labels Apr 1, 2025

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Apr 1, 2025

cmsbuild added pending-signatures hold and removed fully-signed labels Apr 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a test for missing dictionaries with CUDA headers [15.0.x] #47732

Add a test for missing dictionaries with CUDA headers [15.0.x] #47732

fwyzard commented Mar 29, 2025 •

edited

Loading

fwyzard commented Mar 29, 2025

cmsbuild commented Mar 29, 2025 •

edited

Loading

cmsbuild commented Mar 29, 2025 •

edited

Loading

fwyzard commented Mar 29, 2025

fwyzard commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 31, 2025

fwyzard commented Mar 31, 2025

cmsbuild commented Mar 31, 2025

fwyzard commented Mar 31, 2025

cmsbuild commented Apr 1, 2025

fwyzard commented Apr 1, 2025

cmsbuild commented Apr 1, 2025

mandrenguyen commented Apr 2, 2025

cmsbuild commented Apr 2, 2025

Add a test for missing dictionaries with CUDA headers [15.0.x] #47732

Are you sure you want to change the base?

Add a test for missing dictionaries with CUDA headers [15.0.x] #47732

Conversation

fwyzard commented Mar 29, 2025 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

fwyzard commented Mar 29, 2025

cmsbuild commented Mar 29, 2025 • edited Loading

cmsbuild commented Mar 29, 2025 • edited Loading

fwyzard commented Mar 29, 2025

fwyzard commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

cmsbuild commented Mar 29, 2025

Comparison Summary

cmsbuild commented Mar 31, 2025

fwyzard commented Mar 31, 2025

cmsbuild commented Mar 31, 2025

Unit Tests

Comparison Summary

fwyzard commented Mar 31, 2025

cmsbuild commented Apr 1, 2025

Comparison Summary

fwyzard commented Apr 1, 2025

cmsbuild commented Apr 1, 2025

mandrenguyen commented Apr 2, 2025

cmsbuild commented Apr 2, 2025

fwyzard commented Mar 29, 2025 •

edited

Loading

cmsbuild commented Mar 29, 2025 •

edited

Loading

cmsbuild commented Mar 29, 2025 •

edited

Loading