[HLTrigger/Egamma] fix swapped eta parameter for photons in Diphoton XGBoost MVA filter (15_0_X)

[smorovic]

PR description:

Bugfix for a wrong barrel/eta cut chosen for photon pair when photons are in barrel and endcap and leading Et photon in the EGamma collection taken for the combination does not have higher MVA score than the second one.
Variables are renamed to etai, etaj for clarity.

PR validation:

Tested on full /dev/CMSSW_15_0_0/GRun/V23 menu extended with additional 60 GeV mass cut paths /users/smorovic/2025_GRun_V23/V4 .
On 100k EphemeralHLTPhysics (/Run2024I/EphemeralHLTPhysics0/RAW/v1/000/386/593/) events, there is no change in number of accepted events, which are between 27 and 83 events depending on the path, in any paths using the filter.

One case where difference was observed was with a simplified case of all MVA cuts set to flat >0.4 EB and >0.3 EE and no mass cut (set to 0), on 10k EphemeralHLTPhysics events, where 4 (5) events passed in the two 90 GeV DiphotonMVA paths and 3(4) with the fix applied.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #47753

[cmsbuild]

A new Pull Request was created by @smorovic for CMSSW_15_0_X.

It involves the following packages:

• HLTrigger/Egamma (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from [HLTrigger/Egamma] fix swapped eta parameter for photons in Diphoton XGBoost MVA filter (15_1_X) #47753

[cmsbuild]

cms-bot internal usage

[mmusich]

backport of #47753

[mmusich]

@cmsbuild, please test

[mmusich]

type bug-fix

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44e3a3/45329/summary.html
COMMIT: ca30afe
CMSSW: CMSSW_15_0_X_2025-04-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47754/45329/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard AlpakaServiceSerialSync should always be available [15.0.x] #47673
• @fwyzard Fix Service type name displayed in error message [15.0.x] #47671
• @fwyzard Remove legacy CUDA modules for HCAL unpacking and local reconstruction [15.0.x] #47733
• @cms-tsg-storm [15.0.X] remove hardcoded IP substitution for dbproxy option of hltGetConfiguration #47705
• @kandrosov [15_0_X] Adding L1TauTriggerFilterObjectProducer (backport) #47722
• @y19y19 fix a bug in miniAOD_tools.py backport to CMSSW_15_0_X #47715
• @kakwok [15_0_X] Update 2025 HMT shower thresholds for pp collision #47727
• @asavincms Include L1Calo ZS modifications from 15_1_X to 15_0_x #47741

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44e3a3/45329/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44e3a3/45329/git-merge-result

Comparison Summary

Summary:

• You potentially removed 314 lines from the logs
• Reco comparison results: 354 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3999716
• DQMHistoTests: Total failures: 5840
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 3993845
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.41600000000000026 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0,... ): -0.008 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 11634.0,... ): -0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 11634.0,... ): -0.004 KiB MessageLogger/Warnings
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[cmsbuild]

Pull request #47754 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[cmsbuild]

Pull request #47754 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[smorovic]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44e3a3/45343/summary.html
COMMIT: 40bc36e
CMSSW: CMSSW_15_0_X_2025-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47754/45343/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3999716
• DQMHistoTests: Total failures: 52
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3999644
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 48 workflows

[mmusich]

+hlt

• verbatim backport of [HLTrigger/Egamma] fix swapped eta parameter for photons in Diphoton XGBoost MVA filter (15_1_X) #47753 to the 2025 data-taking release.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

urgent

• for next 15_0_X release for data taking
• FYI @cms-sw/orp-l2
• FYI @mpresill as next ORM

[mandrenguyen]

+1