Skip to content

set crossedBoundary_ only for classVersion 12 of the SimTrack #47765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

AuroraPerego
Copy link
Contributor

PR description:

As spotted in this comment, the read rule for the SimTracks introduced in #47682 works only with ClassVersion 12. This PR changes the rule accordingly and adds another one for ClassVersion < 12.

PR validation:

Should be tested with wf 301.0

FYI @dan131riley

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2025

A new Pull Request was created by @AuroraPerego for master.

It involves the following packages:

  • SimDataFormats/Track (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @apsallid, @bsunanda, @denizsun, @fabiocos, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @salimcerci, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 2, 2025

test parameters:
workflow = 29888.208,301.0
relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 2, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c0291/45341/summary.html
COMMIT: 407308b
CMSSW: CMSSW_15_1_X_2025-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47765/45341/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4134555
  • DQMHistoTests: Total failures: 77
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4134457
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 29888.208 ): -0.004 KiB MessageLogger/Warnings
  • Checked 223 log files, 192 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 2, 2025

+simulation

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 54a31a8 into cms-sw:master Apr 2, 2025
12 checks passed
@kpedro88
Copy link
Contributor

kpedro88 commented Apr 2, 2025

@AuroraPerego can you prepare a combined backport of this PR and #47682 for 15_0_X, since #46979 entered that release? thanks!

@AuroraPerego
Copy link
Contributor Author

@AuroraPerego can you prepare a combined backport of this PR and #47682 for 15_0_X, since #46979 entered that release? thanks!

yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants