-
Notifications
You must be signed in to change notification settings - Fork 4.4k
set crossedBoundary_
only for classVersion 12 of the SimTrack
#47765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47765/44345 |
A new Pull Request was created by @AuroraPerego for master. It involves the following packages:
@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
+1 Size: This PR adds an extra 20KB to repository
Comparison SummarySummary:
|
+simulation |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@AuroraPerego can you prepare a combined backport of this PR and #47682 for 15_0_X, since #46979 entered that release? thanks! |
yes! |
PR description:
As spotted in this comment, the read rule for the
SimTrack
s introduced in #47682 works only withClassVersion
12. This PR changes the rule accordingly and adds another one forClassVersion
< 12.PR validation:
Should be tested with wf 301.0
FYI @dan131riley