Migrate LST inputs to SoA collections

[ariostas]

This PR refactors the LST inputs so that Portable SoA Collections are used from the very beginning. It also deduplicates some code since there were separate functions for standalone and CMSSW that played the same role.

It's mostly done, but we have a couple of questions (probably for @fwyzard or @makortel).

1. Running on CPU works fine, but I'm still having issues with GPUs. The issue is with LCG dictionaries, as I described in my Mattermost message. Initially, I thought that the ROOT name normalization issue that Matti mentioned could be the cause, but I think it's something else.
2. I had to split an SoA collection into two, since part of it is created before LST and some needs to be modified during the algorithm (to add some extra data). Do you know of a good way to combine the two collections into some sort of combined view, or do we just need to keep using the two separately. (Obviously, we could just define some new struct or class, but that doesn't sound great to me)

c.c. @slava77 @VourMa

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44377

• Found files with invalid states:
  • RecoTracker/LSTCore/interface/LSTInput.h:
    • Added: c202fe6
    • Modified: b39f14d, 38eca30, 0bb4f24
    • Deleted: 5cc9872
  • RecoTracker/LSTCore/interface/alpaka/HitsRangesDeviceCollection.h:
    • Added: c202fe6
    • Deleted: b39f14d
  • RecoTracker/LSTCore/interface/HitsRangesHostCollection.h:
    • Added: c202fe6
    • Deleted: b39f14d
  • RecoTracker/LSTCore/interface/alpaka/LSTInputDeviceCollection.h:
    • Added: b39f14d
    • Deleted: 0ba4c29

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44377/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44377/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44377/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44377/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44378

• Found files with invalid states:
  • RecoTracker/LSTCore/interface/LSTInput.h:
    • Added: c202fe6
    • Modified: b39f14d, 38eca30, 0bb4f24
    • Deleted: 5cc9872
  • RecoTracker/LSTCore/interface/alpaka/HitsRangesDeviceCollection.h:
    • Added: c202fe6
    • Deleted: b39f14d
  • RecoTracker/LSTCore/interface/HitsRangesHostCollection.h:
    • Added: c202fe6
    • Deleted: b39f14d
  • RecoTracker/LSTCore/interface/alpaka/LSTInputDeviceCollection.h:
    • Added: b39f14d
    • Deleted: 0ba4c29

[cmsbuild]

A new Pull Request was created by @ariostas for master.

It involves the following packages:

• DQM/TrackingMonitorSource (dqm)
• HLTrigger/Configuration (hlt)
• RecoTracker/IterativeTracking (reconstruction)
• RecoTracker/LST (reconstruction)
• RecoTracker/LSTCore (reconstruction)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @SohamBhattacharya, @VinInn, @VourMa, @arossi83, @dgulhan, @felicepantaleo, @fioriNTU, @gpetruc, @idebruyn, @jandrea, @missirol, @mmusich, @mtosi, @richa2710, @rovere, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[ariostas]

Hmm I see that now there's #47697 and #47774, so these are all likely related issues

[slava77]

test parameters:

• enable_tests = gpu
• workflows_gpu = 29634.704,29834.704
• workflows = 29634.703,29834.703,29834.755
• relvals_opt = -w upgrade,standard
• relvals_opt_gpu = -w upgrade,standard

[slava77]

@cmsbuild please test

[VourMa]

@slava77 I would propose we start testing also the .755 workflow to make sure that LST in Phase 2 HLT works fine.
In this particular case, I expect that workflow to crash in more than one ways, which I can follow up on and resolve once the rest of the issues are fixed.

[slava77]

@slava77 I would propose we start testing also the .755 workflow to make sure that LST in Phase 2 HLT works fine. In this particular case, I expect that workflow to crash in more than one ways, which I can follow up on and resolve once the rest of the issues are fixed.

I don't see an accelerator specifier in this workflow.
Is it expected to be added to the CPU or GPU list?

[VourMa]

Is it expected to be added to the CPU or GPU list?

It should be in the "workflows" (not the "workflows_gpu") list.

[cmsbuild]

-1

Failed Tests: RelVals-CUDA RelVals-ROCM
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5bdf1/45418/summary.html
COMMIT: 650b643
CMSSW: CMSSW_15_1_X_2025-04-07-1100/el8_amd64_gcc12
Additional Tests: CUDA,ROCM
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47793/45418/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 323 differences found in the comparisons
• DQMHistoTests: Total files compared: 54
• DQMHistoTests: Total histograms compared: 4206802
• DQMHistoTests: Total failures: 7529
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4199253
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.316 KiB( 53 files compared)
• DQMHistoSizes: changed ( 29634.703,... ): -0.158 KiB Tracking/TrackParameters
• Checked 231 log files, 200 edm output root files, 54 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #47793 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @rseidita can you please check and sign again.

[jfernan2]

assign heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[slava77]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44518

[cmsbuild]

Pull request #47793 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @mmusich, @rseidita can you please check and sign again.

[ariostas]

There's still an issue I'm tracking down, so I'll mark this as a draft until it's ready.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47793/44535

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/Common/src/classes_def.xml modified in PR(s): SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU #47629

[cmsbuild]

Pull request #47793 was updated.