Skip to content

Fix docs in relval_gpu.py #47795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix docs in relval_gpu.py #47795

merged 1 commit into from
Apr 14, 2025

Conversation

VourMa
Copy link
Contributor

@VourMa VourMa commented Apr 6, 2025

Following up on the #46967 (comment) by @fwyzard, this PR adds to the documentation of relval_gpu.py for the changes made in that PR.

Code according to code-checks and code-format.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47795/44386

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2025

A new Pull Request was created by @VourMa for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Apr 6, 2025 via email

@AdrianoDee
Copy link
Contributor

+pdmv

@AdrianoDee
Copy link
Contributor

please test
(the definition of formality)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-498599/45398/summary.html
COMMIT: d387ebc
CMSSW: CMSSW_15_1_X_2025-04-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47795/45398/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor

gentle ping @cms-sw/upgrade-l2

@Moanwar
Copy link
Contributor

Moanwar commented Apr 14, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6b584ae into cms-sw:master Apr 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants