Skip to content

15_0_X Backport: Make ReserveDMu skim throw exception upon mismatch in requested trigg… #47816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

LinaresToine
Copy link
Contributor

The ongoing raw skims development, which is described in PR #47525 uses the ReserveDMu skim that was previously available. The skim is not throwing exception when the corresponding Global Tag has mismatches in the requested triggers, so when using such problematic GT in replay we see empty output files. We must make sure that we get paused jobs to prevent trash data from being produced. The change in this PR aims to ensure we get paused jobs and have the ability to retry the jobs and get the desired output data.

The dummy GT was provided by AlCa, details available in cms-talk. Such global tag was tested on the repacking of stream ParkingDoubleMuonLowMass0 and we see all output files with 0 events.

This is a backport to CMSSW_15_0_X for upcoming data taking. The respective Master PR is: #47813

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2025

A new Pull Request was created by @LinaresToine for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @DickyChant, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @denizsun, @fabiocos, @missirol, @salimcerci, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2025

Pull request #47816 was updated. @AdrianoDee, @cmsbuild, @DickyChant, @miquork can you please check and sign again.

@AdrianoDee
Copy link
Contributor

please test

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2025

please test

I think we're still missing the GTs for this one, right? @cms-sw/alca-l2 ?

@AdrianoDee
Copy link
Contributor

Right, I had missed that piece :-/
(here and in all the other back ports)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d131b/45554/summary.html
COMMIT: 9e6ef57
CMSSW: CMSSW_15_0_X_2025-04-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47816/45554/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 15-Apr-2025 12:50:37 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing  Event run: 165121 lumi: 62 event: 23609118 stream: 0
   [1] Running path 'ReserveDMuPath'
   [2] Calling method for module HLTHighLevel/'ReserveDMu'
Exception Message:
requested pattern "HLT_Dimuon0_Jpsi3p5_Muon2_v*" does not match any HLT paths
----- End Fatal Exception -------------------------------------------------

@perrotta
Copy link
Contributor

Here it is the update of the GT in autoCond: #47871

@perrotta
Copy link
Contributor

please test with #47871

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d131b/45562/summary.html
COMMIT: 9e6ef57
CMSSW: CMSSW_15_0_X_2025-04-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47816/45562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4007714
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4007656
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants