Skip to content

[15_0_X] Plugin to obtain the best track index for Run3ScoutingElectron #47836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: CMSSW_15_0_X
Choose a base branch
from
Open

[15_0_X] Plugin to obtain the best track index for Run3ScoutingElectron #47836

wants to merge 1 commit into from

Conversation

arsahasransu
Copy link
Contributor

PR description:

The new plugin returns the best track index and other associated variables as value maps for use in NanoAOD creation for HLTSCOUT dataset. Discussed extensively in Scouting meeting. Relevant slides are linked below.

Also includes a test functionality in the test directory to manually verify the sensibility of the code output.

PR validation:

scram b code-checks
scram b code-format
scram b runtests
  • Cross-checked the output of code tests/run_Run3ScoutingElectronBestTrack_cfg.py. The values of the edmValueMaps in the root file are sensible.

Backport:

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Apr 10, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2025 •
edited
Loading

A new Pull Request was created by @arsahasransu for CMSSW_15_0_X.

It involves the following packages:

  • PhysicsTools/Scouting (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2025 •
edited
Loading

cms-bot internal usage

@arsahasransu
Copy link
Contributor Author

@cmsbuild +backport

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2025

backport of #47726

@mmusich
Copy link
Contributor

mmusich commented Apr 10, 2025

@cmsbuild, please test

  • @arsahasransu can you make apparent from the title this is targeting 15_0_X ?

@arsahasransu arsahasransu changed the title Add plugin to obtain an unique best track index for Run 3 Scouting El… [15_0_X] Plugin to obtain the best track index for Run3ScoutingElectron Apr 10, 2025
@arsahasransu
Copy link
Contributor Author

  • @arsahasransu can you make apparent from the title this is targeting 15_0_X ?

Done!!

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83a642/45488/summary.html
COMMIT: 48a9796
CMSSW: CMSSW_15_0_X_2025-04-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47836/45488/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4005338
  • DQMHistoTests: Total failures: 67
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4005251
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83a642/45556/summary.html
COMMIT: 48a9796
CMSSW: CMSSW_15_0_X_2025-04-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47836/45556/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4007714
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4007659
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.115 3.115 0.000 ( +0.0% ) 6.82 5.46 +25.0% 2.585 2.584
2500.002 3.231 3.231 0.000 ( +0.0% ) 6.10 5.03 +21.2% 3.040 3.007
2500.003 3.172 3.172 0.000 ( +0.0% ) 6.33 5.13 +23.3% 3.006 2.999
2500.011 1.647 1.647 0.000 ( +0.0% ) 11.47 9.12 +25.8% 2.670 2.658
2500.012 2.185 2.185 0.000 ( +0.0% ) 6.38 5.21 +22.5% 2.862 2.845
2500.013 2.002 2.002 0.000 ( +0.0% ) 9.00 7.05 +27.6% 2.768 2.759
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.91 1.47 +30.0% 2.711 2.693
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.81 1.31 +38.7% 2.710 2.704
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.76 1.37 +28.3% 2.570 2.569
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.45 1.01 +43.6% 2.816 2.802
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.53 1.10 +38.7% 2.779 2.769
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.66 1.16 +42.7% 2.727 2.719
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.58 1.10 +42.6% 2.812 2.800
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.61 1.16 +38.8% 2.790 2.782
2500.101 2.872 2.872 0.000 ( +0.0% ) 15.67 11.29 +38.7% 2.648 2.637
2500.111 1.474 1.474 0.000 ( +0.0% ) 30.20 22.76 +32.7% 2.341 2.333
2500.112 1.896 1.896 0.000 ( +0.0% ) 25.40 18.89 +34.4% 2.416 2.405
2500.131 0.750 0.750 0.000 ( +0.0% ) 36.32 30.42 +19.4% 1.510 1.499
2500.201 2.706 2.706 0.000 ( +0.0% ) 12.71 9.06 +40.2% 2.223 2.215
2500.211 1.845 1.845 0.000 ( +0.0% ) 26.57 18.83 +41.1% 2.419 2.405
2500.212 2.243 2.243 0.000 ( +0.0% ) 22.43 19.67 +14.0% 2.503 2.491
2500.221 2.141 2.141 0.000 ( +0.0% ) 13.86 10.85 +27.7% 2.139 2.128
2500.222 3.516 3.516 0.000 ( +0.0% ) 13.13 9.35 +40.4% 2.229 2.221
2500.223 10.328 10.328 0.000 ( +0.0% ) 4.58 3.60 +27.1% 2.397 2.388
2500.224 6.622 6.622 0.000 ( +0.0% ) 1.25 1.02 +21.7% 2.352 2.338
2500.225 6.671 6.671 0.000 ( +0.0% ) 1.15 0.96 +20.4% 2.570 2.556
2500.226 3.210 3.210 0.000 ( +0.0% ) 13.51 9.21 +46.7% 2.224 2.218
2500.227 1.442 1.442 0.000 ( +0.0% ) 23.51 18.20 +29.2% 1.451 1.440
2500.228 4.045 4.045 0.000 ( +0.0% ) 8.80 6.73 +30.6% 2.330 2.316
2500.231 1.516 1.516 0.000 ( +0.0% ) 22.22 17.17 +29.4% 2.323 2.312
2500.232 2.502 2.502 0.000 ( +0.0% ) 20.91 14.82 +41.1% 2.413 2.393
2500.233 5.422 5.422 0.000 ( +0.0% ) 6.90 5.51 +25.3% 2.572 2.557
2500.234 3.928 3.928 0.000 ( +0.0% ) 1.60 1.25 +28.0% 2.493 2.479
2500.235 3.960 3.960 0.000 ( +0.0% ) 1.49 1.21 +22.8% 2.689 2.686
2500.236 2.292 2.292 0.000 ( +0.0% ) 22.10 18.44 +19.9% 2.411 2.400
2500.237 1.018 1.018 0.000 ( +0.0% ) 34.68 28.42 +22.0% 1.468 1.458
2500.238 2.477 2.477 0.000 ( +0.0% ) 16.91 13.18 +28.3% 2.480 2.467
2500.241 9.404 9.404 0.000 ( +0.0% ) 7.82 5.14 +52.0% 1.933 1.927
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.69 1.33 +26.5% 1.732 1.726
2500.243 2.712 2.712 0.000 ( +0.0% ) 15.72 12.06 +30.4% 1.064 1.062
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.14 0.91 +25.1% 1.688 1.678
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.52 1.12 +36.3% 1.693 1.669
2500.251 645.333 645.333 0.000 ( +0.0% ) 1.65 1.21 +37.0% 1.789 1.769
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.76 1.32 +33.7% 2.822 2.823
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.69 1.33 +26.6% 2.780 2.757
2500.901 1.819 1.819 0.000 ( +0.0% ) 45.58 32.55 +40.0% 1.444 1.432
2500.902 1.665 1.665 0.000 ( +0.0% ) 47.18 42.37 +11.3% 1.345 1.333
2500.911 14.345 14.345 0.000 ( +0.0% ) 9.32 5.10 +82.8% 1.096 1.087
2500.912 0.240 0.150 0.090 ( +59.9% ) 2.30 2.46 -6.5% 0.857 0.848
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.60 2.45 +6.1% 0.858 0.850

@ftorrresd
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed orp-pending tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@arsahasransu @cmsbuild @mmusich @ftorrresd