Skip to content

[NGT] Introduce HGCal validation at HLT #47892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 16, 2025

PR description:

The goal of this PR is to introduce the HGCal validation for the Phase-2 HLT menu.
In order to do so a new validation chain has been added, starting from the existing offline one, and plugged in the Phase-2 HLT validation infrastructure.
The new code supports both the TICL v4 (current default in the phase-2 HLT menu) and TICL v5 (which will become the new default after full validation from the various POGs at HLT). The list of TICL iterations to run upon is based on the process modifier.
In order to cope with the fact that at HLT not all the events have all the collections produced, several producer needed to be patched in order to be protected against missing input.

PR validation:

Run the following set of workflows:

runTheMatrix.py --what upgrade -l 29634.0,29634.75,29634.752,29634.77

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, it will not be backported.

N.B.: opening in draft mode for now, some clean-up is still in order.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 16, 2025

test parameters:

  • relvals_opt = --what upgrade
  • workflows = 29634.0,29634.75,29634.752,29634.77

@mmusich
Copy link
Contributor Author

mmusich commented Apr 16, 2025

type ngt

@cmsbuild cmsbuild added the ngt label Apr 16, 2025
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47892/44538

@mmusich
Copy link
Contributor Author

mmusich commented Apr 16, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6be194/45595/summary.html
COMMIT: fad97fb
CMSSW: CMSSW_15_1_X_2025-04-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47892/45595/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 45 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3929710
  • DQMHistoTests: Total failures: 54
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3929636
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 381607.666 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 24834.911,... ): 42355.207 KiB HLT/HGCAL
  • DQMHistoSizes: changed ( 29634.752 ): 42766.010 KiB HLT/HGCAL
  • Checked 221 log files, 188 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants