Skip to content

[15.0.X] Fix siPixelDigiMorphing modifer and create workflows to test it #47895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 17, 2025

Backport of #47872

PR description:

Title says it all.

PR validation:

Run runTheMatrix.py -l 16834.18

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #47872 to CMSSW_15_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @makortel, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @slomeo, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2025

test parameters:

  • relvals_opt = --what upgrade
  • workflows = 16834.18

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef5cc/45607/summary.html
COMMIT: 1604dc2
CMSSW: CMSSW_15_0_X_2025-04-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47895/45607/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 29696.0, 24834.911, 4.22, 5.1, 4.53, 7.3, 8, 9.0, 135.4, 136.731, 136.793, 136.874, 17034.0, 139.001, 140.045, 141.042, 12434.0, 145.014, 145.104, 145.202, 145.301, 145.408, 145.5, 25, 1306.0, 14234.0, 12834.0, 12834.7, 12846.0, 1330, 13234.0, 29700.0, 312.0, 140.56, 16834.0, 29634.0, 2500.201, 29634.911, 29634.75, 14034.0, 29834.999, 250202.181, 145.604, 145.713, 101.0, 1000, 1001, 13034.0, 10224.0, 25202.0, 11634.0
ValueError: Undefined workflows: 16834.18

@mmusich mmusich force-pushed the mm_dev_PixelDigiMorphing_wfs_15_0_X branch from 1604dc2 to 028f421 Compare April 17, 2025 12:46
@cmsbuild
Copy link
Contributor

Pull request #47895 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ef5cc/45613/summary.html
COMMIT: 028f421
CMSSW: CMSSW_15_0_X_2025-04-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47895/45613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4007714
  • DQMHistoTests: Total failures: 66
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4007628
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@mmusich
Copy link
Contributor Author

mmusich commented Apr 22, 2025

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you have a look, sign?

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Apr 22, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2f8e77c into cms-sw:CMSSW_15_0_X Apr 23, 2025
10 checks passed
@mmusich mmusich deleted the mm_dev_PixelDigiMorphing_wfs_15_0_X branch April 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants