Skip to content

btvNano: store all PS weights [150X] #47905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

mseidel42
Copy link
Contributor

PR description:

Backport of #47904

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2025

A new Pull Request was created by @mseidel42 for CMSSW_15_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2025

cms-bot internal usage

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bac056/45626/summary.html
COMMIT: 5f93b59
CMSSW: CMSSW_15_0_X_2025-04-17-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47905/45626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4007714
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4007688
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1193 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 90269
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 90269
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 22 files compared)
  • Checked 113 log files, 65 edm output root files, 23 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.115 3.115 0.000 ( +0.0% ) 6.87 6.17 +11.3% 2.572 2.571
2500.002 3.231 3.231 0.000 ( +0.0% ) 6.05 5.55 +9.1% 3.003 3.009
2500.003 3.172 3.172 0.000 ( +0.0% ) 6.35 5.82 +9.2% 2.993 2.983
2500.011 1.647 1.647 0.000 ( +0.0% ) 11.46 10.40 +10.2% 2.665 2.659
2500.012 2.185 2.185 0.000 ( +0.0% ) 6.38 5.81 +9.9% 2.845 2.857
2500.013 2.002 2.002 0.000 ( +0.0% ) 9.04 8.17 +10.7% 2.750 2.757
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.87 1.78 +5.3% 2.706 2.696
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.78 1.72 +3.4% 2.701 2.698
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.73 1.64 +5.4% 2.568 2.560
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.44 1.39 +4.0% 2.801 2.807
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.55 1.54 +0.6% 2.765 2.764
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.56 1.54 +0.7% 2.714 2.724
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.51 1.32 +13.9% 2.795 2.802
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.55 1.50 +3.4% 2.789 2.779
2500.101 2.872 2.872 0.000 ( +0.0% ) 15.92 14.43 +10.4% 2.641 2.641
2500.111 1.474 1.474 0.000 ( +0.0% ) 30.91 27.82 +11.1% 2.338 2.338
2500.112 1.896 1.896 0.000 ( +0.0% ) 25.89 23.27 +11.3% 2.404 2.409
2500.131 0.750 0.750 0.000 ( +0.0% ) 36.78 33.63 +9.4% 1.508 1.398
2500.201 2.706 2.706 0.000 ( +0.0% ) 12.88 11.56 +11.4% 2.212 2.154
2500.211 1.845 1.845 0.000 ( +0.0% ) 27.15 23.57 +15.2% 2.409 2.409
2500.212 2.243 2.243 0.000 ( +0.0% ) 22.84 20.81 +9.8% 2.495 2.487
2500.221 2.141 2.141 0.000 ( +0.0% ) 13.75 12.68 +8.4% 2.127 2.068
2500.222 3.516 3.516 0.000 ( +0.0% ) 13.22 12.00 +10.1% 2.219 2.164
2500.223 10.328 10.328 0.000 ( +0.0% ) 4.71 4.21 +11.8% 2.377 2.321
2500.224 6.622 6.622 0.000 ( +0.0% ) 1.25 1.12 +11.5% 2.342 2.342
2500.225 6.671 6.671 0.000 ( +0.0% ) 1.16 1.05 +10.4% 2.550 2.548
2500.226 3.210 3.210 0.000 ( +0.0% ) 13.67 12.33 +10.9% 2.217 2.215
2500.227 1.442 1.442 0.000 ( +0.0% ) 23.34 21.63 +7.9% 1.441 1.440
2500.228 4.045 4.045 0.000 ( +0.0% ) 8.69 8.01 +8.4% 2.319 2.320
2500.231 1.516 1.516 0.000 ( +0.0% ) 22.95 19.71 +16.4% 2.311 2.316
2500.232 2.502 2.502 0.000 ( +0.0% ) 21.07 19.22 +9.6% 2.401 2.402
2500.233 5.422 5.422 0.000 ( +0.0% ) 6.99 6.19 +13.0% 2.563 2.568
2500.234 3.928 3.928 0.000 ( +0.0% ) 1.56 1.41 +10.8% 2.488 2.484
2500.235 3.960 3.960 0.000 ( +0.0% ) 1.51 1.37 +10.0% 2.666 2.678
2500.236 2.292 2.292 0.000 ( +0.0% ) 21.71 20.16 +7.7% 2.392 2.395
2500.237 1.018 1.018 0.000 ( +0.0% ) 34.27 31.67 +8.2% 1.456 1.460
2500.238 2.477 2.477 0.000 ( +0.0% ) 16.94 15.52 +9.1% 2.472 2.469
2500.241 9.404 9.404 0.000 ( +0.0% ) 6.69 6.37 +5.1% 1.938 1.919
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.63 1.56 +4.5% 1.727 1.720
2500.243 2.712 2.712 0.000 ( +0.0% ) 16.05 15.27 +5.1% 1.059 1.061
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.13 1.09 +4.2% 1.695 1.680
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.51 1.45 +4.1% 1.690 1.686
2500.251 645.333 645.333 0.000 ( +0.0% ) 1.66 1.55 +6.9% 1.781 1.779
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.73 1.62 +7.2% 2.811 2.813
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.65 1.56 +6.3% 2.786 2.763
2500.901 1.819 1.819 0.000 ( +0.0% ) 42.93 42.16 +1.8% 1.435 1.432
2500.902 1.665 1.665 0.000 ( +0.0% ) 44.20 44.64 -1.0% 1.335 1.339
2500.911 14.345 14.345 0.000 ( +0.0% ) 8.61 8.52 +1.1% 1.086 1.086
2500.912 0.310 0.171 0.140 ( +81.9% ) 3.33 3.38 -1.7% 0.848 0.846
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.68 2.45 +9.4% 0.850 0.849

@ftorrresd
Copy link
Contributor

backport of #47904

@ftorrresd
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5514c8d into cms-sw:CMSSW_15_0_X Apr 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants