Skip to content

PPS DQM update for the beginning of 2025 data-taking #47909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025

Conversation

AndreaBellora
Copy link
Contributor

PR description:

This PR affects the axis range of the pixel track distributions, to match with the position that they will take because of the geometry update (#47666). The changes are needed for 2025 pp data taking, so a backport has been already opened in (#47826)

PR validation:

Private validation was performed by running the PPS DQM sequence with this config file.

  • Data used: ~10k events from Run2024I/ZeroBias/RAW/v1/000/386/951/
  • GT: 150X_dataRun3_Prompt_PPS_w9_v2 (candidate that applies 2025 geometry to any run)
    • Real data with the new geometry are not yet available, but the test with 2024 data, applying 2025 geometry, is equivalent

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AndreaBellora for master.

It involves the following packages:

  • DQM/CTPPS (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aae289/45665/summary.html
COMMIT: 2bb8d66
CMSSW: CMSSW_15_1_X_2025-04-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47909/45665/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3916361
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 304
  • DQMHistoTests: Total successes: 3916017
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -165940.69799999995 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -7472.250 KiB CTPPS/TrackingPixel
  • DQMHistoSizes: changed ( 10224.0,... ): -429.688 KiB CTPPS/common
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6555de4 into cms-sw:master Apr 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants