Skip to content

BPH NanoAODs backport to CMSSW_15_0_X #47911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: CMSSW_15_0_X
Choose a base branch
from
Open

BPH NanoAODs backport to CMSSW_15_0_X #47911

wants to merge 4 commits into from

Conversation

gmelachr
Copy link
Contributor

This is the backport of #47603 to CMSSW_15_0_X

FYI: @drkovalskyi @gkaratha @ftorrresd @vlimant @jfernan2 @makortel

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Apr 19, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2025 •
edited
Loading

A new Pull Request was created by @gmelachr for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DataFormats/PatCandidates (xpog, reconstruction)
  • PhysicsTools/BPHNano (****)
  • PhysicsTools/NanoAOD (xpog)
  • TrackingTools/TransientTrack (reconstruction)

The following packages do not have a category, yet:

PhysicsTools/BPHNano
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @VinInn, @VourMa, @abbiendi, @andrea21z, @bellan, @cericeci, @dgulhan, @fabiocos, @felicepantaleo, @gouskos, @gpetruc, @hatakeyamak, @jhgoh, @makortel, @missirol, @mmusich, @mtosi, @rovere, @slomeo, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2025 •
edited
Loading

cms-bot internal usage

@gmelachr gmelachr mentioned this pull request Apr 19, 2025
Open
@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54af7a/45648/summary.html
COMMIT: 479b0ff
CMSSW: CMSSW_15_0_X_2025-04-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47911/45648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-NANO
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54af7a/45651/summary.html
COMMIT: 479b0ff
CMSSW: CMSSW_15_0_X_2025-04-21-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47911/45651/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-NANO

  • 2500.2392500.239_ScoutingNANOwithPromptdata140Xrun3/step2_ScoutingNANOwithPromptdata140Xrun3.log

Comparison Summary

Summary:

@gmelachr
Merge pull request #22 from gmelachr/from-CMSSW_15_0_4_patch3
875657e 
fix relval_nano for backport to CMSSW_15_0
@cmsbuild
Copy link
Contributor

Pull request #47911 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@gmelachr
Copy link
Contributor Author

Hi, the file that was giving the failed check has been fixed. Could you please request the tests for one more time?

@vlimant
Copy link
Contributor

vlimant commented Apr 22, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54af7a/45671/summary.html
COMMIT: 875657e
CMSSW: CMSSW_15_0_X_2025-04-22-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47911/45671/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 408 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 90269
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 90269
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 22 files compared)
  • Checked 89 log files, 49 edm output root files, 23 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.229-size.json
  • Nano ERROR: Missing ref/2500.229-size.json
  • Nano ERROR: Missing ref/2500.239-size.json
  • Nano ERROR: Missing ref/2500.239-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.001 | 3.115 | 3.115 | 0.000 ( +0.0% ) | 6.95 | 5.03 | +38.1% | 2.575 | 2.576 |
    | 2500.002 | 3.231 | 3.231 | 0.000 ( +0.0% ) | 6.06 | 4.61 | +31.5% | 3.011 | 3.013 |
    | 2500.003 | 3.172 | 3.172 | 0.000 ( +0.0% ) | 6.48 | 4.56 | +42.0% | 2.982 | 2.981 |
    | 2500.011 | 1.647 | 1.647 | 0.000 ( +0.0% ) | 11.71 | 7.82 | +49.7% | 2.675 | 2.656 |
    | 2500.012 | 2.185 | 2.185 | 0.000 ( +0.0% ) | 6.54 | 4.79 | +36.6% | 2.844 | 2.843 |
    | 2500.013 | 2.002 | 2.002 | 0.000 ( +0.0% ) | 9.23 | 5.94 | +55.4% | 2.759 | 2.752 |
    | 2500.021 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.82 | 1.49 | +22.3% | 2.701 | 2.699 |
    | 2500.022 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.70 | 1.25 | +36.6% | 2.699 | 2.694 |
    | 2500.023 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.69 | 1.02 | +65.3% | 2.564 | 2.566 |
    | 2500.024 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.42 | 1.01 | +40.3% | 2.811 | 2.795 |
    | 2500.031 | 0.035 | 0.035 | 0.000 ( +0.0% ) | 1.62 | 1.03 | +57.0% | 2.759 | 2.756 |
    | 2500.032 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.51 | 1.36 | +11.3% | 2.718 | 2.725 |
    | 2500.033 | 0.037 | 0.037 | 0.000 ( +0.0% ) | 1.56 | 0.94 | +66.1% | 2.805 | 2.803 |
    | 2500.034 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.54 | 1.06 | +45.9% | 2.787 | 2.788 |
    | 2500.101 | 2.872 | 2.872 | 0.000 ( +0.0% ) | 15.74 | 10.54 | +49.4% | 2.638 | 2.638 |
    | 2500.111 | 1.474 | 1.474 | 0.000 ( +0.0% ) | 29.82 | 19.80 | +50.6% | 2.334 | 2.334 |
    | 2500.112 | 1.896 | 1.896 | 0.000 ( +0.0% ) | 25.51 | 14.17 | +80.0% | 2.407 | 2.403 |
    | 2500.131 | 0.750 | 0.750 | 0.000 ( +0.0% ) | 37.43 | 26.16 | +43.1% | 1.505 | 1.500 |
    | 2500.201 | 2.706 | 2.706 | 0.000 ( +0.0% ) | 13.59 | 9.62 | +41.3% | 2.214 | 2.208 |
    | 2500.211 | 1.845 | 1.845 | 0.000 ( +0.0% ) | 27.34 | 16.45 | +66.2% | 2.410 | 2.392 |
    | 2500.212 | 2.243 | 2.243 | 0.000 ( +0.0% ) | 22.46 | 13.33 | +68.5% | 2.493 | 2.484 |
    | 2500.221 | 4.071 | 2.141 | 1.931 ( +90.2% ) | 12.77 | 9.23 | +38.4% | 2.198 | 2.126 |
    | 2500.222 | 2.141 | 3.516 | -1.375 ( -39.1% ) | 13.68 | 8.37 | +63.4% | 2.130 | 2.213 |
    | 2500.223 | 3.516 | 10.328 | -6.812 ( -66.0% ) | 12.80 | 2.91 | +339.3% | 2.224 | 2.387 |
    | 2500.224 | 10.328 | 6.622 | 3.706 ( +56.0% ) | 4.73 | 0.81 | +483.6% | 2.385 | 2.332 |
    | 2500.225 | 6.622 | 6.671 | -0.049 ( -0.7% ) | 1.28 | 0.76 | +68.3% | 2.330 | 2.558 |
    | 2500.226 | 6.671 | 3.210 | 3.461 ( +107.8% ) | 1.20 | 8.93 | -86.5% | 2.549 | 2.214 |
    | 2500.227 | 3.210 | 1.442 | 1.768 ( +122.6% ) | 13.99 | 15.23 | -8.2% | 2.222 | 1.441 |
    | 2500.228 | 1.442 | 4.045 | -2.603 ( -64.4% ) | 24.24 | 6.55 | +269.9% | 1.452 | 2.316 |
    | 2500.231 | 2.912 | 1.516 | 1.396 ( +92.1% ) | 21.42 | 15.50 | +38.1% | 2.389 | 2.314 |
    | 2500.232 | 1.516 | 2.502 | -0.985 ( -39.4% ) | 22.91 | 12.40 | +84.7% | 2.310 | 2.398 |
    | 2500.233 | 2.502 | 5.422 | -2.921 ( -53.9% ) | 21.93 | 4.83 | +353.6% | 2.398 | 2.562 |
    | 2500.234 | 5.422 | 3.928 | 1.494 ( +38.0% ) | 7.22 | 1.10 | +556.4% | 2.574 | 2.475 |
    | 2500.235 | 3.928 | 3.960 | -0.031 ( -0.8% ) | 1.65 | 1.10 | +49.4% | 2.472 | 2.665 |
    | 2500.236 | 3.960 | 2.292 | 1.668 ( +72.8% ) | 1.55 | 12.18 | -87.2% | 2.670 | 2.387 |
    | 2500.237 | 2.292 | 1.018 | 1.274 ( +125.1% ) | 23.07 | 23.63 | -2.4% | 2.399 | 1.451 |
    | 2500.238 | 1.018 | 2.477 | -1.459 ( -58.9% ) | 35.30 | 13.11 | +169.2% | 1.451 | 2.463 |
    | 2500.241 | 9.404 | 9.404 | 0.000 ( +0.0% ) | 5.17 | 4.61 | +12.3% | 1.929 | 1.925 |
    | 2500.242 | 10.331 | 10.331 | 0.000 ( +0.0% ) | 1.68 | 1.23 | +36.0% | 1.726 | 1.725 |
    | 2500.243 | 2.712 | 2.712 | 0.000 ( +0.0% ) | 15.20 | 9.02 | +68.5% | 1.067 | 1.056 |
    | 2500.244 | 486.016 | 486.016 | 0.000 ( +0.0% ) | 1.15 | 0.76 | +51.1% | 1.683 | 1.680 |
    | 2500.245 | 826.413 | 826.413 | 0.000 ( +0.0% ) | 1.54 | 0.90 | +70.5% | 1.689 | 1.685 |
    | 2500.251 | 645.333 | 645.333 | 0.000 ( +0.0% ) | 1.69 | 1.27 | +33.1% | 1.781 | 1.776 |
    | 2500.301 | 0.021 | 0.021 | 0.000 ( +0.0% ) | 1.75 | 1.00 | +75.5% | 2.820 | 2.811 |
    | 2500.311 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.53 | 1.00 | +53.1% | 2.762 | 2.760 |
    | 2500.901 | 1.819 | 1.819 | 0.000 ( +0.0% ) | 46.14 | 31.63 | +45.9% | 1.436 | 1.431 |
    | 2500.902 | 1.665 | 1.665 | 0.000 ( +0.0% ) | 45.85 | 32.62 | +40.5% | 1.339 | 1.334 |
    | 2500.911 | 14.345 | 14.345 | 0.000 ( +0.0% ) | 8.60 | 5.69 | +51.1% | 1.092 | 1.083 |
    | 2500.912 | 0.240 | 0.171 | 0.069 ( +40.7% ) | 3.05 | 2.83 | +8.0% | 0.851 | 0.847 |
    | 2500.913 | 0.110 | 0.110 | 0.000 ( +0.0% ) | 2.62 | 2.20 | +19.3% | 0.855 | 0.851 |

@ftorrresd
Copy link
Contributor

backport of #47603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport changes-dataformats new-package-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-approved tracking upgrade-pending xpog-pending
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@gmelachr @cmsbuild @jfernan2 @ftorrresd @vlimant