[NGT] add e-gamma sequences to NGT scouting menu #47932
Conversation
|
type ngt |
|
cms-bot internal usage |
|
test parameters:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47932/44587
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
| + hltParticleFlowRecHitECALUnseeded | ||
| + hltParticleFlowClusterECALUncorrectedUnseeded | ||
| + hltParticleFlowClusterECALUnseeded | ||
| + HLTHgcalTiclPFClusteringForEgammaUnseededSequence | ||
| + HLTHgcalTiclPFClusteringForEgamma |
There was a problem hiding this comment.
I'm not sure I understand why we have those two sequences together?
There was a problem hiding this comment.
otherwise the rest of the chain fails?
There was a problem hiding this comment.
Not a good answer 😄
What are the differences between the two sequences? And why do we need them both?
There was a problem hiding this comment.
vs
so:
HLTHgcalTiclPFClusteringForEgammaUnseededSequence = cms.Sequence(
hltHgcalDigis+
hltHGCalUncalibRecHit+
hltHGCalRecHit+
hltParticleFlowRecHitHGC+
hltHgcalLayerClustersEE+
hltHgcalLayerClustersHSci+
hltHgcalLayerClustersHSi+
hltHgcalMergeLayerClusters+
hltFilteredLayerClustersCLUE3DHigh+
hltTiclSeedingGlobal+
hltTiclLayerTileProducer+
hltTiclTrackstersCLUE3DHigh+
hltParticleFlowClusterHGCalFromTICLUnseeded+
hltParticleFlowSuperClusterHGCalFromTICLUnseeded)vs
HLTHgcalTiclPFClusteringForEgamma =cms.Sequence(
hltHgcalDigis+
hltHGCalUncalibRecHit+
hltHGCalRecHit+
hltParticleFlowRecHitHGC+
hltHgcalLayerClustersEE+
hltHgcalLayerClustersHSci+
hltHgcalLayerClustersHSi+
hltHgcalMergeLayerClusters+
hltFilteredLayerClustersCLUE3DHigh+
hltTiclSeedingGlobal+
hltTiclLayerTileProducer+
hltTiclTrackstersCLUE3DHigh+
hltParticleFlowClusterHGCal+
hltParticleFlowSuperClusterHGCal) removing HLTHgcalTiclPFClusteringForEgamma results in:
----- Begin Fatal Exception 23-Apr-2025 10:01:53 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing Event run: 1 lumi: 1 event: 3 stream: 0
[1] Running path 'DST_PFScouting'
[2] Calling method for module PFClusterRefCandidateProducer/'hltPfClusterRefsForJetsHGCAL'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::PFCluster
Looking for module label: hltParticleFlowClusterHGCal
Looking for productInstanceName:
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
removing HLTHgcalTiclPFClusteringForEgammaUnseededSequence results in:
----- Begin Fatal Exception 23-Apr-2025 10:06:09 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing Event run: 1 lumi: 1 event: 3 stream: 0
[1] Running path 'DST_PFScouting'
[2] Calling method for module EgammaHLTRecoEcalCandidateProducers/'hltEgammaCandidatesUnseeded'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::SuperCluster>
Looking for module label: hltParticleFlowSuperClusterECALUnseeded
Looking for productInstanceName: particleFlowSuperClusterECALBarrel
Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------
There was a problem hiding this comment.
It turns out that the sequence HLTHgcalTiclPFClusteringForEgamma was needed only by the other sequence HLTJMESequence, which in turn is apparently used only by a "MC" path (MC_JME):
cmssw/HLTrigger/Configuration/python/HLT_75e33/paths/MC_JME_cfi.py
Lines 15 to 27 in 24690bd
which we don't want to run in the scouting menu. In the last push I removed the HLTHgcalTiclPFClusteringForEgamma and the HLTJMESequence sequences.
|
+1 Size: This PR adds an extra 20KB to repository
Comparison SummarySummary:
|
mmusich
force-pushed
the
mm_dev_add_egamma_NGTScouting
branch
from
142944c to
b8e4b2d
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47932/44591
|
|
Pull request #47932 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 20KB to repository
Comparison SummarySummary:
|
|
For record this is the change in timing:
So we go from 6.1851s to 6.0275s i.e. a -2.54% reduction (which we can attribute to the removal of the |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
After the integration of PR #47901 and the subsequent check of the timing of the NGT scouting menu (integrated back in #47434) it became apparent that none of the e-gamma related parts of the pie were being executed, see e.g. for reference here:
The goal of this PR is to introduce said sequences in order to generate the event products foreseen for the NGT scouting.
PR validation:
Run successfully the workflow:
runTheMatrix.py --what upgrade -l 29634.77 -t 4 -j 8.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not to be backported.
Cc: @rovere