-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[GCC14] Avoid Wdangling-reference in EcalUncalibRecHitPhase2WeightsAlgoPortable.dev.cc #47945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…goPortable.dev.cc
cms-bot internal usage |
please test for el8_amd64_gcc14 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47945/44610 |
A new Pull Request was created by @iarspider for master. It involves the following packages:
@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 24KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd64f6/45710/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@fwyzard FYI. |
hold |
Pull request has been put on hold by @fwyzard |
@iarspider can you check the generated assembler and ptx code for this kind of changes, to make sure they are safe ? |
@fwyzard I can try, but I don't have any experience with assembly. I think the generated code will be the same in both cases, the compiler should optimize out the intermediate variable |
PR description:
Title says it all. Build log:
PR validation:
No warning when building locally.