Skip to content

Conversation

@smuzaffar
Copy link
Contributor

This fixes GCC 14 build error [a]

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el9_amd64_gcc14/CMSSW_15_1_ROOT636_X_2025-06-12-1100/PerfTools/AllocMonitor

[src/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc:44](https://github.com/cms-sw/cmssw/blob/CMSSW_15_1_ROOT636_X_2025-06-12-1100/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc#L44):23: error: 'max_element' is not a member of 'std'; did you mean 'tuple_element'?
    44 |     auto itMax = std::max_element(iModuleLabels.begin(), iModuleLabels.end(), [](auto const& iL, auto const& iR) {
      |                       ^~~~~~~~~~~
      |                       tuple_element
  [src/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc:47](https://github.com/cms-sw/cmssw/blob/CMSSW_15_1_ROOT636_X_2025-06-12-1100/PerfTools/AllocMonitor/plugins/monitor_file_utilities.cc#L47):55: error: no matching function for call to 'edm::OStreamColumn::OStreamColumn(<brace-enclosed initializer list>)'
    47 |     OStreamColumn labelCol{iLabelHeader, itMax->size()};

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Jun 17, 2025
@smuzaffar smuzaffar changed the title [GCC14]Included algorithm for std::max_element [GCC14]Included header algorithm for std::max_element Jun 17, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • PerfTools/AllocMonitor (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @makortel this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_15_1_ROOT636_X/el9_amd64_gcc14

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f54f8b/46796/summary.html
COMMIT: 39dc3a9
CMSSW: CMSSW_15_1_X_2025-06-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48344/46796/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4050825
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4050801
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f54f8b/46798/summary.html
COMMIT: 39dc3a9
CMSSW: CMSSW_15_1_ROOT636_X_2025-06-12-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48344/46798/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f54f8b/46798/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f54f8b/46798/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
101.0 step 1
10224.0 step 1
11634.0 step 1
12434.0 step 1
12834.0 step 1
12846.0 step 1
13034.0 step 1
1306.0 step 1
13234.0 step 1
1330.0 step 1
135.4 step 1
136.731 step 2
136.793 step 2
136.874 step 2
139.001 step 2
140.045 step 2
140.56 step 2
14034.0 step 1
141.042 step 2
14234.0 step 1
145.014 step 2
145.104 step 2
145.202 step 2
145.301 step 2
145.408 step 2
145.5 step 2
145.604 step 2
145.713 step 2
16834.0 step 1
17034.0 step 1
24834.911 step 1
25.0 step 1
2500.301 step 2
250202.181 step 1
25202.0 step 1
29634.0 step 1
29634.75 step 1
29634.911 step 1
29696.0 step 1
29700.0 step 1
29834.999 step 1
312.0 step 1
4.22 step 2
4.53 step 2
5.1 step 1
7.3 step 1
8.0 step 1
9.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 2151994 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 69 log files, 0 edm output root files, 1 DQM output files

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit da8c21e into cms-sw:master Jun 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants