-
Notifications
You must be signed in to change notification settings - Fork 4.6k
protect online DQM clients when running in inputFiles mode against meaningless customizations
#48705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protect online DQM clients when running in inputFiles mode against meaningless customizations
#48705
Conversation
inputFiles mode against meaningless customizations
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48705/45740
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
|
@cms-sw/dqm-l2 do you have comments on this one? |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
no, the fix you proposes to circumvent the issue is ok with us, thanks for catching it |
|
+1 |
PR description:
Title says it all.
When developing a test for CMSHLT-3534 I realized that certain online client configurations customize the event source as if it was a
DQMStreamerReadereven in the case it whichoptions.inputFilesis not null. In that case as per this code here:cmssw/DQM/Integration/python/config/inputsource_cfi.py
Lines 125 to 132 in 6a7da0e
the source gets changed to a traditional
PoolSourceand the customization doesn't make sense, hence leading to runtime errors.This PR introduces protections to circumvent the issue.
PR validation:
Run successfully the following script in
CMSSW_15_0_12on a file produced with theGRunmenu proposed in CMSHLT-3534.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A