Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 8, 2025

PR description:

This PR is similar in spirit to #47017, #47045, #47079, #47107, #47136, #47191 and #47224, towards solving issue #47275.
It adds fillDescriptions (and applies light modification to modernize the source code) to a few EDProducers used at HLT for both Run 3 and Phase 2.

PR validation:

  • addOnTests.py runs fine.
  • hltPhase2UpgradeIntegrationTests runs fine.
  • runTheMatrix.py -l limited runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48858/46012

@mmusich
Copy link
Contributor Author

mmusich commented Sep 8, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2025

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecc03a/48001/summary.html
COMMIT: 3b1e2f7
CMSSW: CMSSW_15_1_X_2025-09-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48858/48001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4346948
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4346890
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 223 log files, 194 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@mmusich mmusich marked this pull request as ready for review September 8, 2025 11:15
@mmusich
Copy link
Contributor Author

mmusich commented Sep 8, 2025

test parameters:

  • enable = hlt_p2_integration
  • workflows = ph2_hlt

@mmusich
Copy link
Contributor Author

mmusich commented Sep 8, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CalibCalorimetry/HcalPlugins (alca)
  • CalibTracker/SiPixelESProducers (alca)
  • Geometry/CaloEventSetup (geometry)
  • RecoLocalCalo/CaloTowersCreator (reconstruction)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HcalRecAlgos (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • RecoLocalMuon/RPCRecHit (reconstruction)
  • TrackingTools/MaterialEffects (reconstruction)

@Dr15Jones, @arunhep, @atpathak, @bsunanda, @civanch, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @perrotta can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @ReyerBand, @VinInn, @VourMa, @abdoulline, @apsallid, @argiro, @bellan, @bsunanda, @denizsun, @dgulhan, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @jhgoh, @mariadalfonso, @martinamalberti, @missirol, @mmusich, @mroguljic, @mtosi, @rchatter, @rovere, @rsreds, @salimcerci, @thomreis, @tocheng, @tsusa, @tvami, @wang0jin, @youyingli, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2025

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecc03a/48010/summary.html
COMMIT: 3b1e2f7
CMSSW: CMSSW_15_1_X_2025-09-08-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48858/48010/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2025

+alca

  • For CalibCalorimetry and CalibTracker

@civanch
Copy link
Contributor

civanch commented Sep 8, 2025

+geometry

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 8, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 727b6d9 into cms-sw:master Sep 8, 2025
12 checks passed
@mmusich mmusich deleted the mm_fillDesc_forHLT branch September 8, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants