Skip to content

Conversation

@srimanob
Copy link
Contributor

PR description:

This is a partial backport of #48153
Note that, since I don't do backport for all workflows that added in between, including 20242024HLTOnDigi, 2024HLTOnDigiPU, 2024GenOnly, 2024SimOnGen, so I add an exception on workflow numbers in this PR. So the 2024FS workflow has the same id with CMSSW_14_2_X, and later.

Without dedicated 2024FS workflow, we will face an issue when try to run FastSim

Principal::getByLabel: Found zero products matching all criteria
Looking for type: std::vector<PSimHit>
Looking for module label: g4SimHits
Looking for productInstanceName: MuonGEMHits

PR validation:

Run 16434.0 and it works fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2025

A new Pull Request was created by @srimanob for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@AdrianoDee, @Moanwar, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @ftenchini, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2025

cms-bot internal usage

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 16434.0
  • relvals_opt = --what cleanedupgrade

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@srimanob
Copy link
Contributor Author

Hi @cms-sw/orp-l2
Do you have a plan on building new 14_0? This PR is needed to create FastSim 2024 campaign. It would be good to have it by the next 14_0. Thanks.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c2eb2/48270/summary.html
COMMIT: a437058
CMSSW: CMSSW_14_0_X_2025-09-21-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48991/48270/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3349879
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3349853
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

@DickyChant
Copy link

+pdmv

@iarspider
Copy link
Contributor

@cmsbuild ping

@mandrenguyen
Copy link
Contributor

backport of #48153

@mandrenguyen
Copy link
Contributor

Hi @cms-sw/orp-l2 Do you have a plan on building new 14_0? This PR is needed to create FastSim 2024 campaign. It would be good to have it by the next 14_0. Thanks.

No, there hasn't been any request for a new 14_0_X release. Given the pace of 14_0_X releases, I would propose to simply build a patch.

@mandrenguyen
Copy link
Contributor

+1
Given the deprecation of the upgrade signature, I will leave this open a couple of hours in case of comments before merging in time for the 11AM IB.

@Moanwar
Copy link
Contributor

Moanwar commented Sep 26, 2025

+Upgrade
Just signing off the opening PRs from the Upgrade side to avoid complications, since the Upgrade group will be merged with Reconstruction.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1935bf5 into cms-sw:CMSSW_14_0_X Sep 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants