Filter LayerClusters for TICL Recovery PR by AlgoID and Size

[waredjeb]

This PR filters the LCs in input to the Recovery by PR by size and AlgoID. This is needed where for the ticlBarrel procModifier as the barrel and HGCAL layerclusters are merged in a single collection.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49023/46223

[cmsbuild]

A new Pull Request was created by @waredjeb for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)
• RecoHGCal/TICL (reconstruction, upgrade)

@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @apsallid, @denizsun, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @mmusich, @rovere, @salimcerci, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• enable = hlt_p2_timing, hlt_p2_integration
• workflows = ph2_hlt

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87b35b/48338/summary.html
COMMIT: dc47b82
CMSSW: CMSSW_16_0_X_2025-09-28-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING,HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49023/48338/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 2024.0010001DAS Error

• HLT P2 Timing: chart

[felicepantaleo]

ignore tests-rejected with ib-failure

[felicepantaleo]

allow @waredjeb test rights

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87b35b/48395/summary.html
COMMIT: dc47b82
CMSSW: CMSSW_16_0_X_2025-10-01-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING,HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49023/48395/install.sh to create a dev area with all the needed externals and cmssw changes.

• HLT P2 Timing: chart

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 64
• DQMHistoTests: Total histograms compared: 4273420
• DQMHistoTests: Total failures: 1316
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4272084
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 63 files compared)
• Checked 263 log files, 223 edm output root files, 64 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[Moanwar]

+Upgrade

[mmusich]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

Is this safe to merge even with the failed test? I see it's set to be ignored.

[mmusich]

Is this safe to merge even with the failed test?

I think it's a relic from the previous test. The last round is successful #49023 (comment). Not sure why the dashboard was not cleaned. You might want to investigate with core.

[iarspider]

Is this safe to merge even with the failed test?

Not sure why the dashboard was not cleaned.

Because we moved the default compiler to gcc13 between two tests. We can't remove old statues, only update them.

[ftenchini]

Ok thanks. I think the same is happening in #49040. It seems like the tests indeed passed, so I'll merge now so it can make into the morning IB.

@makortel @smuzaffar could you please check what's going on with the dashboard?

EDIT: Ah, thanks @iarspider

[ftenchini]

+1